Bug 1692281 - operator should deploy a service-monitor

openshift / ansible-service-broker

Ansible Service Broker

Apache License 2.0

226 stars 84 forks source link

Bug 1692281 - operator should deploy a service-monitor #1204

Closed fabianvf closed 5 years ago

fabianvf commented 5 years ago

Describe what this PR does and why we need it:

This makes the Ansible Service Broker Operator deploy a ServiceMonitor for the Ansible Service Broker, allowing it to expose metrics to prometheus.

https://bugzilla.redhat.com/show_bug.cgi?id=1692281

coveralls commented 5 years ago

Coverage remained the same at 40.97% when pulling fb6e18720947e042a86be906da6c37035b7eb3ef on fabianvf:service-monitor into b0e7eb54d25b1f95167b1b03a9523e923250b14d on openshift:master.

fabianvf commented 5 years ago

/retest

jmrodri commented 5 years ago

Commit should have the Bug number in it. Change the commit to be Bug 1692281 - operator should deploy a service-monitor

jmrodri commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, jmrodri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ansible-service-broker/blob/master/OWNERS)~~ [jmrodri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment