search

openshift / ansible-service-broker

Ansible Service Broker
Apache License 2.0
226 stars 84 forks source link

Pass *_PROXY envvars on to ASB deployment #1237

Closed fabianvf closed 5 years ago

fabianvf commented 5 years ago

Describe what this PR does and why we need it:

OLM will be setting these variables on operator deployments and we need to pass them through to deployments created by the operator

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 40.97% when pulling 5fb3465e31b41a7481c12d256bf4c5ed80ad8749 on fabianvf:proxy-envvars into 59ce86c3e38a221bf67619e2f503b87a68aa54ac on openshift:master.

shawn-hurley commented 5 years ago

/retest

shawn-hurley commented 5 years ago

/retest

shawn-hurley commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianvf, shawn-hurley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ansible-service-broker/blob/master/OWNERS)~~ [shawn-hurley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment