search

openshift / ansible-service-broker

Ansible Service Broker
Apache License 2.0
226 stars 84 forks source link

Bug 1782058: Allow ASBO to access endpoints #1261

Closed jmrodri closed 4 years ago

jmrodri commented 4 years ago

also remove TODO comment left over from previous PR https://github.com/openshift/ansible-service-broker/pull/1256/files#r345233931

openshift-ci-robot commented 4 years ago

@jmrodri: This pull request references Bugzilla bug 1782058, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/ansible-service-broker/pull/1261): >Bug 1782058: Allow ASBO to access endpoints Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 40.97% when pulling d471a5cabb4138c7bef7c160cd39c6b189474595 on bz1782058-fix-metrics into f02d26529802b3180ca607307fcdee7cb78baf8f on master.

jmrodri commented 4 years ago

/retest

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ansible-service-broker/blob/master/OWNERS)~~ [jmrodri,joelanford] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 years ago

@jmrodri: All pull requests linked via external trackers have merged. Bugzilla bug 1782058 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/ansible-service-broker/pull/1261): >Bug 1782058: Allow ASBO to access endpoints Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.