openshift / ansible-service-broker

Ansible Service Broker
Apache License 2.0
226 stars 84 forks source link

Update make deploy to use openshift-asbo to match downstream #1269

Closed jmrodri closed 4 years ago

jmrodri commented 4 years ago

The make deploy-operator used ansible-service-broker-operator which is fine but doesn't match what the OLM deployed operator would be. This makes it difficult to recreate the production install from the development code. By using openshift-ansible-service-broker-operator this will mimic the downstream a little closer. Also, undeploy-operator didn't seem to work when it was a single line.

openshift-ci-robot commented 4 years ago

@jmrodri: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/ansible-service-broker/pull/1269): >Update make deploy to use openshift-asbo to match downstream Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ansible-service-broker/blob/release-4.3/OWNERS)~~ [jmrodri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 40.97% when pulling 96f4f738a3c5472152118c0621a0d986c22fde46 on fix-makefile-builds into a05e355d0e1bc7cbfefa45c36abc68116e1e4796 on release-4.3.

openshift-ci-robot commented 4 years ago

@jmrodri: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/operator-molecule-olm-e2e e1390c1d6b6347dce886e8816192a34727f330c3 link /test operator-molecule-olm-e2e
ci/prow/operator-molecule-e2e e1390c1d6b6347dce886e8816192a34727f330c3 link /test operator-molecule-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jmrodri commented 4 years ago

/hold