search

openshift / ansible-service-broker

Ansible Service Broker
Apache License 2.0
226 stars 84 forks source link

optimization: simplify the provision duplication detection code #99

Closed jmrodri closed 7 years ago

jmrodri commented 7 years ago

Provision could call DeepEqual twice which can be expensive.

https://github.com/fusor/ansible-service-broker/blob/master/pkg/broker/broker.go#L197-L217

Also remove the logging of parameters which could contain sensitive information.

jmrodri commented 7 years ago

Basically make it look lie this. https://github.com/fusor/ansible-service-broker/blob/master/pkg/broker/broker.go#L351-L362