search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

CORS-3582: remove unused installer feature gates #1950

Closed r4f4 closed 4 weeks ago

r4f4 commented 2 months ago

The CAPI features gates are not needed anymore for platforms where CAPI provisioning is the default.

Also CAPI/aws replaced the AWS SDK provisioner, so the AlternateInfrastructureAWS feature gate is not needed anymore.

openshift-ci-robot commented 2 months ago

@r4f4: This pull request references CORS-3582 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/1950): >The CAPI features gates are not needed anymore for platforms where CAPI provisioning is the default. > >Also CAPI/aws replaced the AWS SDK provisioner, so the AlternateInfrastructureAWS feature gate is not needed anymore. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

Hello @r4f4! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

r4f4 commented 2 months ago

This is being done in conjunction with https://github.com/openshift/installer/pull/8703

/cc @patrickdillon

r4f4 commented 2 months ago

/cc @rvanderp3 @yanhua121 @stephenfin

openshift-ci[bot] commented 2 months ago

@r4f4: GitHub didn't allow me to request PR reviews from the following users: yanhua121.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/api/pull/1950#issuecomment-2208519432): >/cc @rvanderp3 @yanhua121 @stephenfin Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
JoelSpeed commented 2 months ago

/hold

I'll check with @sdodson and @deads2k when they are back, but, I believe at the moment we cannot remove gates, only promote or remove from feature sets. I think there are some tooling limitations.

We may have to defer this until 4.18

r4f4 commented 2 months ago

If we defer to 4.18, we might be able to remove all capi gates.

This is not a blocker in any way, since the installer can just ignore the gates for platforms using capi by default. It's more of a tech debt.

sdodson commented 2 months ago

/retest-required

r4f4 commented 2 months ago

Update: rebased to fix merge conflicts.

r4f4 commented 1 month ago

Update: rebased to fix merge conflicts and added Azure, GCP, and PowerVS to the list of removed gates.

r4f4 commented 1 month ago

Update: rebased to fix merge conflicts.

JoelSpeed commented 1 month ago

/lgtm /retest

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
r4f4 commented 1 month ago

/label acknowledge-critical-fixes-only The requirement for the label has already been dropped.

r4f4 commented 1 month ago

@JoelSpeed are we good to remove the hold now?

JoelSpeed commented 4 weeks ago

/hold cancel

openshift-ci-robot commented 4 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 85dc560939ef05322ce0b204174e9a02c5376c19 and 2 for PR HEAD b667a6fb641055e0dc22cdc4888b7204bd164479 in total

openshift-ci[bot] commented 4 weeks ago

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409021542.p0.g9e399f5.assembly.stream.el9. All builds following this will include this PR.