openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

OCPBUGS-36469: Update placementGroupPartition to pointer #1953

Closed chiragkyal closed 2 months ago

chiragkyal commented 2 months ago

Since this API does not support kubebuilder marker validations, we added the range validation (1-7) as a webhook validation, which will run after that value got defaulted to 0.

However, as discussed in https://issues.redhat.com/browse/CFE-1066, there is a semantic difference between unset and 0

Making this field as pointer would help differentiate between unset and 0

openshift-ci-robot commented 2 months ago

@chiragkyal: This pull request references Jira Issue OCPBUGS-36469, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/1953): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

Hello @chiragkyal! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

chiragkyal commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@chiragkyal: This pull request references Jira Issue OCPBUGS-36469, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sunzhaohua2

In response to [this](https://github.com/openshift/api/pull/1953#issuecomment-2213185508): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chiragkyal commented 2 months ago

/cc @huali9

JoelSpeed commented 2 months ago

For validation reasons, we need to have a distinction between a nil value and a user specifying the 0 value explicitly, a pointer while adding complexity, solves this /lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@chiragkyal: This pull request references Jira Issue OCPBUGS-36469, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sunzhaohua2

In response to [this](https://github.com/openshift/api/pull/1953): >Since this API does not support kubebuilder marker validations, we added the [range validation (1-7)](https://github.com/openshift/machine-api-operator/pull/1265) as a webhook validation, which will run after that value got defaulted to 0. > >However, as discussed in https://issues.redhat.com/browse/CFE-1066, there is a semantic difference between unset and 0 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@chiragkyal: Jira Issue OCPBUGS-36469: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-36469 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/api/pull/1953): >Since this API does not support kubebuilder marker validations, we added the [range validation (1-7)](https://github.com/openshift/machine-api-operator/pull/1265) as a webhook validation, which will run after that value got defaulted to 0. > >However, as discussed in https://issues.redhat.com/browse/CFE-1066, there is a semantic difference between unset and 0 > >Making this field as pointer would help differentiate between unset and `0` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407082010.p0.gc9a9194.assembly.stream.el9 for distgit ose-cluster-config-api. All builds following this will include this PR.