Closed chiragkyal closed 2 months ago
@chiragkyal: This pull request references Jira Issue OCPBUGS-36469, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
Hello @chiragkyal! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
/jira refresh
@chiragkyal: This pull request references Jira Issue OCPBUGS-36469, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @sunzhaohua2
/cc @huali9
For validation reasons, we need to have a distinction between a nil value and a user specifying the 0
value explicitly, a pointer while adding complexity, solves this
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chiragkyal, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@chiragkyal: This pull request references Jira Issue OCPBUGS-36469, which is valid.
Requesting review from QA contact: /cc @sunzhaohua2
@chiragkyal: all tests passed!
Full PR test history. Your PR dashboard.
@chiragkyal: Jira Issue OCPBUGS-36469: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh
.
Jira Issue OCPBUGS-36469 has not been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407082010.p0.gc9a9194.assembly.stream.el9 for distgit ose-cluster-config-api. All builds following this will include this PR.
Since this API does not support kubebuilder marker validations, we added the range validation (1-7) as a webhook validation, which will run after that value got defaulted to 0.
However, as discussed in https://issues.redhat.com/browse/CFE-1066, there is a semantic difference between unset and 0
Making this field as pointer would help differentiate between unset and
0