search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

OCPBUGS-36809: Add missing auth config fields #1955

Open jonesbr17 opened 2 months ago

jonesbr17 commented 2 months ago

The uid and extra fields were added to Kubernetes in 1.29. These fields should be included in OpenShift as well.

openshift-ci-robot commented 2 months ago

@jonesbr17: This pull request references Jira Issue OCPBUGS-36809, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/1955): >The `uid` and `extra` fields were added to Kubernetes in 1.29. >These fields should be included in OpenShift as well. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

Hello @jonesbr17! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

csrwng commented 2 months ago

cc @openshift/api-reviewers

csrwng commented 2 months ago

cc @ibihim

openshift-ci[bot] commented 2 months ago

@rtheis: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/api/pull/1955#pullrequestreview-2175658998): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rtheis commented 2 months ago

/retest-required

rtheis commented 2 months ago

/retest-required

liouk commented 1 month ago

@jonesbr17 could you please adapt/add tests in config/v1/tests/authentications.config.openshift.io/ExternalOIDC.yaml?

jonesbr17 commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

@rtheis: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/api/pull/1955#pullrequestreview-2222157146): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jonesbr17 commented 1 month ago

/retest required

openshift-ci[bot] commented 1 month ago

@jonesbr17: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/api/pull/1955#issuecomment-2274279251): >/retest required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jonesbr17 commented 1 month ago

/retest-required

jonesbr17 commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

@rtheis: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/api/pull/1955#pullrequestreview-2229807325): >/lgtm > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rtheis commented 1 month ago

/test e2e-gcp

rtheis commented 1 month ago

/test e2e-azure

openshift-ci[bot] commented 1 month ago

@jonesbr17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 1cb4e17eb2d6b61ab11e138ab9afba0546910405 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
liouk commented 1 month ago

/lgtm

Assigning to @deads2k for approval as he approved the OIDC API changes in the first place.

/assign @deads2k

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonesbr17, liouk, rtheis Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deads2k commented 1 month ago

Assigning to @deads2k for approval as he approved the OIDC API changes in the first place.

/hold

New fields require a new gate to ensure that our implementation and testing are complete prior to bringing new fields into the API. I also haven't seen an explanation of when, if, and how these fields will be made functional and tested on HCP or OCP. We need to get those explained prior to merging.