search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

Test: Allow admins to disable EgressIP #1957

Open andreaskaris opened 4 months ago

andreaskaris commented 4 months ago

Test: Allow admins to disable EgressIP

openshift-ci[bot] commented 4 months ago

Hello @andreaskaris! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andreaskaris Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@andreaskaris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 4b33cb295b7d2c43cd5a25a7cc1856cda132e4ca link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade 4b33cb295b7d2c43cd5a25a7cc1856cda132e4ca link true /test e2e-upgrade
ci/prow/e2e-aws-serial 4b33cb295b7d2c43cd5a25a7cc1856cda132e4ca link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn 4b33cb295b7d2c43cd5a25a7cc1856cda132e4ca link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift 4b33cb295b7d2c43cd5a25a7cc1856cda132e4ca link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade-minor 4b33cb295b7d2c43cd5a25a7cc1856cda132e4ca link true /test e2e-upgrade-minor
ci/prow/e2e-aws-ovn-techpreview 4b33cb295b7d2c43cd5a25a7cc1856cda132e4ca link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 days ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-merge-robot commented 4 days ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.