search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

OCPNODE-2436: SigstoreImageVerification featuregate marker for the ClusterImagePolicy and ImagePolicy #1964

Closed QiWang19 closed 2 months ago

QiWang19 commented 2 months ago

ClusterImagePolicy and ImagePolicy use SigstoreImageVerification instead of ImagePolicy

openshift-ci[bot] commented 2 months ago

Hello @QiWang19! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

deads2k commented 2 months ago

Is the ImagePolicy featureGate in use? if not, please remove it here.

deads2k commented 2 months ago

/approve

QiWang19 commented 2 months ago

/retest

QiWang19 commented 2 months ago

/test integration

QiWang19 commented 2 months ago

/test verify

wking commented 2 months ago

/retest-required

jupierce commented 2 months ago

/test all

QiWang19 commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, QiWang19, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wking commented 2 months ago

/retitle OCPNODE-2436: SigstoreImageVerification featuregate marker for the ClusterImagePolicy and ImagePolicy

openshift-ci-robot commented 2 months ago

@QiWang19: This pull request references OCPNODE-2436 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1964): >ClusterImagePolicy and ImagePolicy use SigstoreImageVerification instead of ImagePolicy Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 2 months ago

/label acknowledge-critical-fixes-only

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407180110.p0.g8da8de5.assembly.stream.el9 for distgit ose-cluster-config-api. All builds following this will include this PR.