search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

MCO-1064: Disable tech preview #1968

Open dkhater-redhat opened 3 months ago

dkhater-redhat commented 3 months ago

Disabled tech preview for MachineConfigNodes FG

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references MCO-1064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1968): >Disabled tech preview for MachineConfigNodes FG Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

Hello @dkhater-redhat! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkhater-redhat Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoelSpeed commented 3 months ago

/hold

Not clear to me what we are actually trying to achieve here. This is demoting the feature, I expect you actually want to promote the feature. Looking at the related epic, there are still a number of tasks to complete, so this feature is not yet ready to promote anyway.

openshift-merge-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 2ae6d1991a98c951583a87e88a578c784d0876a0 link false /test e2e-gcp
ci/prow/verify 2ae6d1991a98c951583a87e88a578c784d0876a0 link true /test verify
ci/prow/e2e-aws-ovn-hypershift 2ae6d1991a98c951583a87e88a578c784d0876a0 link true /test e2e-aws-ovn-hypershift
ci/prow/integration 2ae6d1991a98c951583a87e88a578c784d0876a0 link true /test integration
ci/prow/minor-e2e-upgrade-minor 374e89ed6b0404c3ef1e325505e115ec1620f39f link true /test minor-e2e-upgrade-minor
ci/prow/minor-images 374e89ed6b0404c3ef1e325505e115ec1620f39f link true /test minor-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 days ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale