search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

Add MCP and Config Version columns to MCN output #1972

Closed dkhater-redhat closed 1 month ago

dkhater-redhat commented 2 months ago

Updated MCN output to include the pool name and config versions. Changed these to a higher priority and redid the priorities on the other columns so they only show up in -o wide

openshift-ci[bot] commented 2 months ago

Hello @dkhater-redhat! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

JoelSpeed commented 1 month ago

Changes look good, have you tested what the output of an oc get machineconfignodes and oc get machineconfignodes -o wide looks like here?

openshift-ci[bot] commented 1 month ago

@dkhater-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dkhater-redhat commented 1 month ago

Had a conversation with Joel and moved all of the required output columns to priority 0. moved the rest to priority 1 so its available when specifying -o wide

djoshy commented 1 month ago

/lgtm from MCO side!

djoshy commented 1 month ago

/lgtm /shrug

JoelSpeed commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, dkhater-redhat, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202408012013.p0.g0b7902a.assembly.stream.el9. All builds following this will include this PR.