search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

MULTIARCH-4770: features: move MultiArchInstall[AWS|GCP] to TechPreview #1973

Closed r4f4 closed 3 months ago

r4f4 commented 3 months ago

The functionality has merged in the Installer.

AWS: https://issues.redhat.com/browse/MULTIARCH-4567 GCP: https://issues.redhat.com/browse/MULTIARCH-4618

AWS multi-arch day-0 periodics: sippy link GCP multi-arch day-0 periodics: sippy link

openshift-ci-robot commented 3 months ago

@r4f4: This pull request references MULTIARCH-4770 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1973): >The functionality has merged in the Installer. > >AWS: https://issues.redhat.com/browse/MULTIARCH-4567 >GCP: https://issues.redhat.com/browse/MULTIARCH-4618 > >AWS multi-arch day-0 periodics: [sippy link](https://sippy.dptools.openshift.org/sippy-ng/jobs/4.17/analysis?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-aws-ovn-heterogeneous-day-0%22%7D%5D%7D) >GCP multi-arch day-0 periodics: [sippy link](https://sippy.dptools.openshift.org/sippy-ng/jobs/4.17/analysis?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-gcp-ovn-heterogeneous-day-0%22%7D%5D%7D) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

Hello @r4f4! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

r4f4 commented 3 months ago

/cc @jeffdyoung

r4f4 commented 3 months ago

Note: even with the feature gate, the feature is only activated in the Installer when controlPlane and compute arches differ.

openshift-ci[bot] commented 3 months ago

@r4f4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 8106d39248155607b122858aa6b606fec6dbe3cc link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
r4f4 commented 3 months ago

/assign @derekwaynecarr

r4f4 commented 3 months ago

/test e2e-aws-ovn-hypershift

r4f4 commented 3 months ago

/unassign @derekwaynecarr /assign @JoelSpeed

I think Derek is out.

JoelSpeed commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408010314.p0.gc299a67.assembly.stream.el9. All builds following this will include this PR.