openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

Run update-payload-crds after update-codegen-crds #1974

Closed Prashanth684 closed 3 months ago

Prashanth684 commented 3 months ago

When working on #1928, noticed that the payload crds were not generated after running a make update. This is because codegen is run after update-scripts. This PR removes update-payload-crds from update-scripts and runs it after codegen.

openshift-ci[bot] commented 3 months ago

Hello @Prashanth684! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

JoelSpeed commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Prashanth684 commented 3 months ago

/retest-required

Prashanth684 commented 3 months ago

/retest-required

openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD 0d46442e8df17a87cfcf6666ab19b28e88620b59 and 2 for PR HEAD d90bbeacb625b238c389284499f74c833014935c in total

Prashanth684 commented 3 months ago

/test e2e-aws-serial-techpreview

openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD e863d9f8a215ce75d09033a69d180922d00a52b9 and 1 for PR HEAD d90bbeacb625b238c389284499f74c833014935c in total

openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD c299a673ec729b7e63a6c363d67e961454218e09 and 0 for PR HEAD d90bbeacb625b238c389284499f74c833014935c in total

openshift-ci-robot commented 3 months ago

/hold

Revision d90bbeacb625b238c389284499f74c833014935c was retested 3 times: holding

openshift-ci[bot] commented 3 months ago

@Prashanth684: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp d90bbeacb625b238c389284499f74c833014935c link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
JoelSpeed commented 3 months ago

/hold cancel /override ci/prow/e2e-aws-ovn

This PR doesn't affect the E2Es

openshift-ci[bot] commented 3 months ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn

In response to [this](https://github.com/openshift/api/pull/1974#issuecomment-2265137118): >/hold cancel >/override ci/prow/e2e-aws-ovn > >This PR doesn't affect the E2Es Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD 8b2b377d9d42634867e281b57218c372fe432cbe and 2 for PR HEAD d90bbeacb625b238c389284499f74c833014935c in total

openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408030144.p0.g7461358.assembly.stream.el9. All builds following this will include this PR.