openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

add new feature for the Insights Runtime Extractor #1976

Closed tremes closed 3 weeks ago

tremes commented 2 months ago

This is the feature described in the https://github.com/openshift/enhancements/pull/1584 and there's no new API required by this feature.

openshift-ci[bot] commented 2 months ago

Hello @tremes! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

JoelSpeed commented 1 month ago

@tremes Are you targeting 4.17 for your feature? We are branching end of the week so wasn't sure if you wanted to still merge this, or wait until we've branched to 4.18

tremes commented 1 month ago

@JoelSpeed No. It's 4.18 so I can wait for the branching.

JoelSpeed commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD d73f2e11e0be768c1f3eef2bacf73bcd7f24c1cd and 2 for PR HEAD 212398b13a7bab3902f95346b73b9cecb78f5b14 in total

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD d73f2e11e0be768c1f3eef2bacf73bcd7f24c1cd and 2 for PR HEAD 212398b13a7bab3902f95346b73b9cecb78f5b14 in total

openshift-ci[bot] commented 3 weeks ago

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409090821.p0.g5852b58.assembly.stream.el9. All builds following this will include this PR.