search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

Power VS: Move Power VS to CAPI by default #1979

Closed mjturek closed 1 month ago

openshift-ci[bot] commented 2 months ago

Hello @mjturek! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

mjturek commented 2 months ago

@JoelSpeed @patrickdillon We are feeling pretty good about the results of the CAPI job, could we merge this? https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-ovn-ppc64le-powervs-capi

JoelSpeed commented 1 month ago

Did we reach a conclusion about whether we are ok not having disconnected support in 4.17?

Do you have a sippy link that shows the jobs over time?

mjturek commented 1 month ago

The conclusion from the multiarch PM is that having the disconnected path for 4.17 be install with 4.16 and upgrade to 4.17 is okay.

I believe the recommendation is a week of data from the periodics. The 4.17 CAPI job was broken until recently so sippy would not show the same success we are currently seeing.

JoelSpeed commented 1 month ago

So I'm looking at both the capi and terraform runs and you're right, both aren't fantastic if you look back over time 😅

But the CAPI runs do appear to be looking good as far as I can tell.

Is there anyone else you need to get an LGTM from before we promote this? Perhaps @patrickdillon?

mjturek commented 1 month ago

absolutely! @patrickdillon I would love your input

patrickdillon commented 1 month ago

absolutely! @patrickdillon I would love your input

This LGTM. I'm happy to see PowerVS go default with CAPI installs.

JoelSpeed commented 1 month ago

/test verify

JoelSpeed commented 1 month ago

/lgtm /override ci/prow/verify

/retest-required

Based on test output mentioned in https://github.com/openshift/api/pull/1979#issuecomment-2263379124, LGTM with Patricks approval

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/1979#issuecomment-2271010000): >/lgtm >/override ci/prow/verify > >/retest-required > >Based on test output mentioned in https://github.com/openshift/api/pull/1979#issuecomment-2263379124, LGTM with Patricks approval Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD e65e6f54eb3c97dfbfb1629cc59646ee43cd6f62 and 2 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total

JoelSpeed commented 1 month ago

/override ci/prow/verify

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/1979#issuecomment-2271506553): >/override ci/prow/verify > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 6b4a57ec20b0bfc77cb3909da4f1a9234d498571 and 1 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total

mjturek commented 1 month ago

/test e2e-aws-ovn-hypershift

JoelSpeed commented 1 month ago

/override ci/prow/verify

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/1979#issuecomment-2273052221): >/override ci/prow/verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3cab566552bbc5c8ce7d11991cbc2bd1f21e1e1b and 0 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total

openshift-ci-robot commented 1 month ago

/hold

Revision c05561f963315bd2bc57e1a30de1ac47ff3a2f9f was retested 3 times: holding

JoelSpeed commented 1 month ago

/hold cancel

JoelSpeed commented 1 month ago

/retest-required

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3cab566552bbc5c8ce7d11991cbc2bd1f21e1e1b and 2 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total

mjturek commented 1 month ago

/retest-required

mjturek commented 1 month ago

/test ci/prow/verify-client-go

openshift-ci[bot] commented 1 month ago

@mjturek: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/api/pull/1979#issuecomment-2274674823): >/test ci/prow/verify-client-go Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mjturek commented 1 month ago

/test verify-client-go

mjturek commented 1 month ago

/test integration

mjturek commented 1 month ago

/test e2e-aws-ovn-hypershift

mjturek commented 1 month ago

/test e2e-azure

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 1ad7d8470d94376ad07078262355e6ed43222fcb and 1 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD bf71d8fa815566f4364c402e6713d3f07222cc14 and 0 for PR HEAD c05561f963315bd2bc57e1a30de1ac47ff3a2f9f in total

JoelSpeed commented 1 month ago

/lgtm /overide ci/prow/verify

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mjturek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoelSpeed commented 1 month ago

/overide ci/prow/verify

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD bf71d8fa815566f4364c402e6713d3f07222cc14 and 2 for PR HEAD 24092e9e858822c07b2ec68b86125da567282a13 in total

JoelSpeed commented 1 month ago

/override ci/prow/verify

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/1979#issuecomment-2276041304): >/override ci/prow/verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@mjturek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 24092e9e858822c07b2ec68b86125da567282a13 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408081846.p0.gcbdcd0d.assembly.stream.el9. All builds following this will include this PR.