search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

[WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 #1983

Open atiratree opened 1 month ago

atiratree commented 1 month ago

TODO:

openshift-ci-robot commented 1 month ago

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to [this](https://github.com/openshift/api/pull/1983): >- WIP: make update not passing Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Hello @atiratree! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to [this](https://github.com/openshift/api/pull/1983): >TODO: >- [ ] depends on https://github.com/openshift/kubernetes-sigs-controller-tools/pull/20 >- [ ] verify-prerelease-lifecycle-gen.sh should be fixed https://github.com/openshift/api/pull/1983/commits/0cbd381a99c4e1383c1a8304845f004c66e38f10 >- [ ] not passing the verify-crd-schema-checker.sh: seeing a lot of `NoNewRequiredFields` >- [ ] OPTIONAL: the rest of the scripts should be ported to gengo: https://github.com/openshift/api/pull/1776 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
atiratree commented 1 month ago

The PR passes make update so we can use it as a dependency for now, but there are still TODOs which are mentioned in the description.

atiratree commented 1 month ago

/test verify-client-go

openshift-ci[bot] commented 1 month ago

@atiratree: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/api/pull/1983#issuecomment-2269464321): >/retest verify-client-go Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to [this](https://github.com/openshift/api/pull/1983): >TODO: >- [ ] depends on https://github.com/openshift/kubernetes-sigs-controller-tools/pull/20 >- [ ] verify-prerelease-lifecycle-gen.sh should be fixed >- [ ] not passing the verify-crd-schema-checker.sh: seeing a lot of `NoNewRequiredFields` >- [ ] OPTIONAL: the rest of the scripts should be ported to gengo: https://github.com/openshift/api/pull/1776 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
atiratree commented 1 month ago

/retest

openshift-ci-robot commented 1 month ago

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/1983): >TODO: >- [x] depends on https://github.com/openshift/kubernetes-sigs-controller-tools/pull/20 >- [x] verify-prerelease-lifecycle-gen.sh should be fixed >- [ ] not passing the verify-crd-schema-checker.sh: seeing a lot of `NoNewRequiredFields` >- [ ] OPTIONAL: the rest of the scripts should be ported to gengo: https://github.com/openshift/api/pull/1776 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
atiratree commented 4 days ago

/test e2e-azure /test minor-e2e-upgrade-minor

openshift-ci-robot commented 3 days ago

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/1983): >TODO: >- [x] depends on https://github.com/openshift/kubernetes-sigs-controller-tools/pull/20 >- [x] verify-prerelease-lifecycle-gen.sh should be fixed >- [x] not passing the verify-crd-schema-checker.sh: seeing a lot of `NoNewRequiredFields` >- [ ] OPTIONAL: the rest of the scripts should be ported to gengo: https://github.com/openshift/api/pull/1776 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
atiratree commented 3 days ago

/test e2e-azure /test minor-e2e-upgrade-minor /test e2e-aws-ovn-hypershift

atiratree commented 2 days ago

/test e2e-azure

openshift-ci[bot] commented 2 days ago

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 3d53ef984bc6a297a7258905a77df8f653d26558 link true /test verify-crd-schema
ci/prow/verify-client-go 3d53ef984bc6a297a7258905a77df8f653d26558 link true /test verify-client-go

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).