openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

CORS-3617: Promote Azure CAPI as the default Install method #1987

Closed sadasu closed 3 months ago

openshift-ci-robot commented 3 months ago

@sadasu: This pull request references CORS-3617 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1987): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

Hello @sadasu! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

sadasu commented 3 months ago

Azure Techpreview job results

sadasu commented 3 months ago

/retest-required

patrickdillon commented 3 months ago

/retest-required

sadasu commented 3 months ago

/retest-required

patrickdillon commented 3 months ago

Techpreview Azure Infrastructure is passing at 97%

Looking through the 4 failures, only one of those appears to be a CAPI-based failure. The rest are Terraform.

That seems to be roughly comparable to default infrastructure provisioning which is at 97.6%

I don't suspect we're going to be able to get verify to pass because it looks like some operators are failing to come up reliably in TechPreview

stbenjam commented 3 months ago

As long as we understand why techpreview installs themselves are unreliable and there's open bugs for them, I think it's fine to override. I agree infrastructure looks comparable between techpreview and non-techpreview.

sadasu commented 3 months ago

/retest-required

sadasu commented 3 months ago

/test verify

sadasu commented 3 months ago

/test verify

patrickdillon commented 3 months ago

/test verify

JoelSpeed commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
patrickdillon commented 3 months ago

/test verify

verify seems wedged, stuck in pending state

JoelSpeed commented 3 months ago

/test verify

openshift-ci[bot] commented 3 months ago

@sadasu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408080814.p0.gbf71d8f.assembly.stream.el9. All builds following this will include this PR.