Closed sadasu closed 3 months ago
Hello @sadasu! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
/retest-required
/retest-required
/retest-required
Techpreview Azure Infrastructure is passing at 97%
Looking through the 4 failures, only one of those appears to be a CAPI-based failure. The rest are Terraform.
That seems to be roughly comparable to default infrastructure provisioning which is at 97.6%
I don't suspect we're going to be able to get verify to pass because it looks like some operators are failing to come up reliably in TechPreview
As long as we understand why techpreview installs themselves are unreliable and there's open bugs for them, I think it's fine to override. I agree infrastructure looks comparable between techpreview and non-techpreview.
/retest-required
/test verify
/test verify
/test verify
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed, sadasu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test verify
verify seems wedged, stuck in pending state
/test verify
@sadasu: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408080814.p0.gbf71d8f.assembly.stream.el9. All builds following this will include this PR.
@sadasu: This pull request references CORS-3617 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.