search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

SDN-4919,SDN-5135: Graduate `UserDefinedNetworks` to GA #1988

Closed tssurya closed 1 month ago

tssurya commented 1 month ago

Depends on https://github.com/openshift/origin/pull/28945

openshift-ci-robot commented 1 month ago

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/1988): >Depends on https://github.com/openshift/origin/pull/28945 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Hello @tssurya! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 1 month ago

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

This pull request references SDN-5135 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1988): >Depends on https://github.com/openshift/origin/pull/28945 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tssurya commented 1 month ago

/payload 4.17 ci blocking /payload 4.17 nightly blocking

openshift-ci[bot] commented 1 month ago

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.17

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6b3a5f50-544c-11ef-905a-6a27a95253c5-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.17

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6b3a5f50-544c-11ef-905a-6a27a95253c5-1

tssurya commented 1 month ago

/retest-required

huiran0826 commented 1 month ago

Below cases passed on both IPv4 and dualstack clusters. cc @anuragthehatter if you have other comments. passed: (2m39s) 2024-08-08T06:47:18 "[sig-networking] SDN udn Author:anusaxen-Critical-74921-Check udn pods isolation on user defined networks" passed: (3m47s) 2024-08-08T06:38:58 "[sig-networking] SDN udn Author:huirwang-High-75223-Restarting ovn pods should not break UDN primary network traffic.[Disruptive] [Serial]" passed: (4m4s) 2024-08-08T06:44:16 "[sig-networking] SDN udn Author:anusaxen-Critical-75236-Check udn pods are not isolated if same nad network is shared across two namespaces"

JoelSpeed commented 1 month ago

/lgtm /override ci/prow/verify

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/1988#issuecomment-2275907595): >/lgtm >/override ci/prow/verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD bf71d8fa815566f4364c402e6713d3f07222cc14 and 2 for PR HEAD f514517e686da5e33a7d847191570d19aabcf492 in total

tssurya commented 1 month ago

/retest-required

anuragthehatter commented 1 month ago

other svc related usecase also looks good to QE

/lgtm

tssurya commented 1 month ago

Ah this needs a rebase

trozet commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anuragthehatter, JoelSpeed, trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD e69593239e4999456536460ed7291001dd32401a and 2 for PR HEAD 5cd96ef1783606e729dfbb5d8e0fccc9b8f23daf in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD d6942fb7294e5dea4c617bfcb26e5936dc267481 and 1 for PR HEAD 5cd96ef1783606e729dfbb5d8e0fccc9b8f23daf in total

tssurya commented 1 month ago

/retest-required

JoelSpeed commented 1 month ago

/override ci/prow/verify

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/1988#issuecomment-2277233941): >/override ci/prow/verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
JoelSpeed commented 1 month ago

Note, this has now missed 4.17 and will need to be backported to 4.17 once merged

trozet commented 1 month ago

/retest-required

openshift-cherrypick-robot commented 1 month ago

@tssurya: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/api/pull/1988#issuecomment-2278148876): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tssurya commented 1 month ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 month ago

@tssurya: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/api/pull/1988#issuecomment-2278149819): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@tssurya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-cherrypick-robot commented 1 month ago

@tssurya: new pull request created: #1995

In response to [this](https://github.com/openshift/api/pull/1988#issuecomment-2278149819): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.