Closed r4f4 closed 1 month ago
@r4f4: This pull request references MULTIARCH-4776 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
Hello @r4f4! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
/cc @jeffdyoung
/lgtm
/test verify
/assign @JoelSpeed
We're very close to the 95% for GCP. AWS already reached that.
error: only 0 tests found, need at least 5 for "MultiArchInstallAWS" on {aws amd64 hypershift}
error: "install should succeed: overall" only passed 94%, need at least 95% for "MultiArchInstallGCP" on {gcp amd64 ha}
The hypershift "0 tests" is expected: it doesn't support arm64 control plane node pools yet and it doesn't use the openshift-install code for provisioning, so these feature gates have no effect there.
/assign @JoelSpeed
We're very close to the 95% for GCP. AWS already reached that.
error: only 0 tests found, need at least 5 for "MultiArchInstallAWS" on {aws amd64 hypershift} error: "install should succeed: overall" only passed 94%, need at least 95% for "MultiArchInstallGCP" on {gcp amd64 ha}
The hypershift "0 tests" is expected: it doesn't support arm64 control plane node pools yet and it doesn't use the openshift-install code for provisioning, so these feature gates have no effect there.
Yeah this doesn't affect HyperShift. We don't use the openshift-install for provisioning.
/test verify
Installer testing of o/api bump: https://github.com/openshift/installer/pull/8808
/test verify
/retest-required
Based on testing information provided above, I think we are good to move forward here /lgtm /override ci/prow/verify
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jeffdyoung, JoelSpeed, r4f4
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify
@r4f4: all tests passed!
Full PR test history. Your PR dashboard.
Add MultiArchInstallAWS and MultiArchInstallGCP to the Default feature set.
AWS multi-arch day-0 periodics: sippy link GCP multi-arch day-0 periodics: sippy link