openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

MULTIARCH-4776: MULTIARCH-4770: installer: promote MultiArchInstall FGs #1991

Closed r4f4 closed 1 month ago

r4f4 commented 1 month ago

Add MultiArchInstallAWS and MultiArchInstallGCP to the Default feature set.

AWS multi-arch day-0 periodics: sippy link GCP multi-arch day-0 periodics: sippy link

openshift-ci-robot commented 1 month ago

@r4f4: This pull request references MULTIARCH-4776 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1991): >Add MultiArchInstallAWS and MultiArchInstallGCP to the Default feature set. > >AWS multi-arch day-0 periodics: [sippy link](https://sippy.dptools.openshift.org/sippy-ng/jobs/4.17/analysis?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-aws-ovn-heterogeneous-day-0%22%7D%5D%7D) >GCP multi-arch day-0 periodics: [sippy link](https://sippy.dptools.openshift.org/sippy-ng/jobs/4.17/analysis?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-gcp-ovn-heterogeneous-day-0%22%7D%5D%7D) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Hello @r4f4! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

r4f4 commented 1 month ago

/cc @jeffdyoung

jeffdyoung commented 1 month ago

/lgtm

r4f4 commented 1 month ago

/test verify

r4f4 commented 1 month ago

/assign @JoelSpeed

We're very close to the 95% for GCP. AWS already reached that.

error: only 0 tests found, need at least 5 for "MultiArchInstallAWS" on {aws amd64 hypershift}
error: "install should succeed: overall" only passed 94%, need at least 95% for "MultiArchInstallGCP" on {gcp amd64 ha} 

The hypershift "0 tests" is expected: it doesn't support arm64 control plane node pools yet and it doesn't use the openshift-install code for provisioning, so these feature gates have no effect there.

bryan-cox commented 1 month ago

/assign @JoelSpeed

We're very close to the 95% for GCP. AWS already reached that.

error: only 0 tests found, need at least 5 for "MultiArchInstallAWS" on {aws amd64 hypershift}
error: "install should succeed: overall" only passed 94%, need at least 95% for "MultiArchInstallGCP" on {gcp amd64 ha} 

The hypershift "0 tests" is expected: it doesn't support arm64 control plane node pools yet and it doesn't use the openshift-install code for provisioning, so these feature gates have no effect there.

Yeah this doesn't affect HyperShift. We don't use the openshift-install for provisioning.

r4f4 commented 1 month ago

/test verify

r4f4 commented 1 month ago

Installer testing of o/api bump: https://github.com/openshift/installer/pull/8808

JoelSpeed commented 1 month ago

/test verify

JoelSpeed commented 1 month ago

/retest-required

JoelSpeed commented 1 month ago

Based on testing information provided above, I think we are good to move forward here /lgtm /override ci/prow/verify

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeffdyoung, JoelSpeed, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/1991#issuecomment-2276273245): >Based on testing information provided above, I think we are good to move forward here >/lgtm >/override ci/prow/verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).