Closed nitin-dhevar closed 2 months ago
Hello @nitin-dhevar! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nitin-dhevar Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/assign @jhadvig
/label tide/merge-method-squash
@nitin-dhevar: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/verify | 01cacf5e79cf873912aca8dc8b97ee1f6e2c0c58 | link | true | /test verify |
ci/prow/images | 01cacf5e79cf873912aca8dc8b97ee1f6e2c0c58 | link | true | /test images |
Full PR test history. Your PR dashboard.
Closing in favor of https://github.com/openshift/api/pull/2015
/close
@jhadvig: Closed this PR.
@nitin-dhevar: This pull request references CONSOLE-4055 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.