search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

MON-3971: Remove MetricsServer feature gate #1993

Open slashpai opened 1 month ago

slashpai commented 1 month ago

cluster-monitoring-operator now by default installs and configures metrics-server and it doesn't need to be behind feature gate anymore.

openshift-ci-robot commented 1 month ago

@slashpai: This pull request references MON-3971 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1993): >cluster-monitoring-operator now by default installs and configures metrics-server and it doesn't need >to be behind feature gate anymore. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Hello @slashpai! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

slashpai commented 1 month ago

/retest

slashpai commented 1 month ago

/retest

slashpai commented 1 month ago

/payload 4.17 nightly blocking

openshift-ci[bot] commented 1 month ago

@slashpai: trigger 9 job(s) of type blocking for the nightly release of OCP 4.17

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/35832820-554f-11ef-9dcc-9fa7f4650624-0

machine424 commented 1 month ago

Thanks!

Maybe we should also clean it in payload-command/render/renderassets/rendered_manifests_test.go?

/hold Let's wait for https://github.com/openshift/api/pull/1780 to set the pace as there are still discussions around "featuregates removing" https://github.com/openshift/api/pull/1780#issuecomment-1993986689

machine424 commented 1 month ago

FYI https://github.com/openshift/api/pull/1780 was merged. Reading the latest discussions, I think we should wait until version 4.19 to merge this one.

JoelSpeed commented 1 month ago

Looking at the slack thread, I think we are ok to move forward, can you rebase please to address conflicts

openshift-ci[bot] commented 4 weeks ago

@slashpai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 49ba8ebd11182d837fb2b3beb08bd2f6973a180b link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
JoelSpeed commented 3 weeks ago

Feature was promoted to GA 4 months ago in 4.17

/lgtm

openshift-merge-robot commented 3 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment