openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

[release-4.17] SDN-4919,SDN-5135: Graduate `UserDefinedNetworks` to GA #1995

Open openshift-cherrypick-robot opened 1 month ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #1988

/assign tssurya

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: SDN-4919, SDN-5135

In response to [this](https://github.com/openshift/api/pull/1995): >This is an automated cherry-pick of #1988 > >/assign tssurya Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

trozet commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, trozet Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/release-4.17/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
trozet commented 1 month ago

/hold

after discussing with @JoelSpeed I think we should wait on lifting the feature gate for UDN in 4.17 until we have fully implemented it and have it tested in 4.17. It is now enabled in 4.18, and we will get sufficient CI coverage there across all jobs. Since 4.17 will be synced to 4.18, we can limit our risk of breaking 4.17 and still get the testing coverage we need in 4.18.

openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure ed4fbd5e311d0eafbb87efceaa27d701e8c13c30 link false /test e2e-azure
ci/prow/e2e-aws-ovn-hypershift ed4fbd5e311d0eafbb87efceaa27d701e8c13c30 link true /test e2e-aws-ovn-hypershift
ci/prow/verify ed4fbd5e311d0eafbb87efceaa27d701e8c13c30 link true /test verify
ci/prow/images ed4fbd5e311d0eafbb87efceaa27d701e8c13c30 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).