search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

OCPBUGS-38414: Revert #1988 "Graduate `UserDefinedNetworks` to GA" #1996

Closed stbenjam closed 3 months ago

stbenjam commented 3 months ago

Reverts #1988 ; tracked by OCPBUGS-38414

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

UDN tests are permafailing on metal

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Test metal with the new UDN tests

CC: @tssurya

PR created by Revertomatic:tm:
openshift-ci[bot] commented 3 months ago

Hello @stbenjam! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 3 months ago

@stbenjam: This pull request references Jira Issue OCPBUGS-38414, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/1996): > >Reverts #1988 ; tracked by OCPBUGS-38414 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >UDN tests are permafailing on metal > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >Test metal with the new UDN tests >``` > >CC: @tssurya > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
stbenjam commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@stbenjam: This pull request references Jira Issue OCPBUGS-38414, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/1996#issuecomment-2286020084): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
JoelSpeed commented 3 months ago

/lgtm

stbenjam commented 3 months ago

We're returning to a known state (the feature gate off)

/label approved /override ci/prow/e2e-gcp /override ci/prow/e2e-aws-serial-techpreview /override ci/prow/e2e-aws-ovn-techpreview /override ci/prow/e2e-aws-ovn-hypershift /override ci/prow/e2e-upgrade-minor /override ci/prow/e2e-upgrade /override ci/prow/e2e-aws-ovn /override ci/prow/e2e-azure /override ci/prow/e2e-aws-serial

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stbenjam commented 3 months ago

/override ci/prow/e2e-aws-ovn /override ci/prow/e2e-aws-ovn-hypershift

openshift-ci[bot] commented 3 months ago

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift

In response to [this](https://github.com/openshift/api/pull/1996#issuecomment-2286074974): >/override ci/prow/e2e-aws-ovn >/override ci/prow/e2e-aws-ovn-hypershift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 months ago

@stbenjam: Jira Issue OCPBUGS-38414: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38414 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/api/pull/1996): > >Reverts #1988 ; tracked by OCPBUGS-38414 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >UDN tests are permafailing on metal > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >Test metal with the new UDN tests >``` > >CC: @tssurya > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408132015.p0.ge48b223.assembly.stream.el9. All builds following this will include this PR.