openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

SDN-4930: Revert "OCPBUGS-38414: Revert #1988 "Graduate `UserDefinedNetworks` to GA"" #1997

Open tssurya opened 3 months ago

tssurya commented 3 months ago

Reverts openshift/api#1996 https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe.

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms)

The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again.

maiqueb commented 1 month ago

/cc

tssurya commented 1 month ago
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-10-09T09:20:10Z"} 
INFO[2024-10-09T09:20:11Z] Ran for 7m58s                                
ERRO[2024-10-09T09:20:11Z] Some steps failed:                           
ERRO[2024-10-09T09:20:11Z] 
  * could not run steps: step verify failed: test "verify" failed: could not watch pod: the pod ci-op-r4ncmic8/verify failed after 7m54s (failed containers: test): ContainerFailed one or more containers exited
Container test exited with code 2, reason Error
---

huh

tssurya commented 1 month ago

/test verify

anuragthehatter commented 1 month ago

@anuragthehatter see if it works now?

Apparently still fails https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1843985077655048192

anuragthehatter commented 1 month ago

@tssurya Thats works. But I am concern about if we can merge asap becuase QE at the moment plays ping-pong with cluster bot builds, one fails one pass etc

tssurya commented 1 month ago

Unfortunately I also got to know this rule only last release but until a feature is FULLY done we can't GA.

I can have segmented FG but that's too much work for us in ovnk. So I am aiming to GA as much core bits as we can in one go

tssurya commented 3 weeks ago

/retest

openshift-ci-robot commented 3 weeks ago

@tssurya: This pull request references SDN-4930 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/1997): >Reverts openshift/api#1996 >https://github.com/openshift/origin/pull/28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe. > >@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms) > >The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-minor 733cabf29eb3a76aaac2326d559a75d50fe52ad5 link true /test e2e-upgrade-minor
ci/prow/e2e-aws-serial-techpreview 6c3551201d1ce5e3b173de87f779fa9245612832 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-serial 6c3551201d1ce5e3b173de87f779fa9245612832 link true /test e2e-aws-serial
ci/prow/verify 6c3551201d1ce5e3b173de87f779fa9245612832 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).