search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

SPLAT-1743: vSphere - add host and vm based zonal #1999

Open jcpowermac opened 1 month ago

jcpowermac commented 1 month ago

Changes

Additional PRs

openshift-ci-robot commented 1 month ago

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1999): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

Hello @jcpowermac! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

jcpowermac commented 1 month ago

(will re-write the commit message with appropriate details once this PR is closer to being ready)

/test build /test e2e-aws-ovn

/test e2e-aws-ovn-techpreview

/test e2e-upgrade /test e2e-upgrade-minor /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps

jcpowermac commented 1 month ago

/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps

jcpowermac commented 1 month ago

/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps

jcpowermac commented 1 month ago

/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps

jcpowermac commented 1 week ago

/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps

jcpowermac commented 1 week ago

/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps

openshift-ci-robot commented 6 days ago

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1999): >### Changes > > > >### Additional PRs > >https://github.com/openshift/api/pull/1999 >https://github.com/openshift/installer/pull/8873 >https://github.com/openshift/client-go/pull/294 >https://github.com/openshift/library-go/pull/1782 >https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325 >https://github.com/openshift/machine-api-operator/pull/1285 > > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 days ago

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1999): >### Changes > > > >### Additional PRs > >https://github.com/openshift/enhancements/pull/1677 >https://github.com/openshift/api/pull/1999 >https://github.com/openshift/installer/pull/8873 >https://github.com/openshift/client-go/pull/294 >https://github.com/openshift/library-go/pull/1782 >https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325 >https://github.com/openshift/machine-api-operator/pull/1285 > > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 days ago

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1999): >### Changes > >- New feature gate `VSphereHostVMGroupZonal` >- Add `RegionType` and `ZoneType` fields to `VSpherePlatformFailureDomainSpec` to specify region and zone failure domain types. >- Add `VSphereFailureDomainAffinity` type that contains three fields required for vm-host zonal: `VMGroup`, `HostGroup` and `VMHostRule`. >- Add `VSphereFailureDomainAffinity` to `VSpherePlatformTopology` >- Create additional unit tests to cover the introduction of vm-host zonal provisioning types. > >### Additional PRs > >https://github.com/openshift/enhancements/pull/1677 >https://github.com/openshift/api/pull/1999 >https://github.com/openshift/installer/pull/8873 >https://github.com/openshift/client-go/pull/294 >https://github.com/openshift/library-go/pull/1782 >https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325 >https://github.com/openshift/machine-api-operator/pull/1285 > > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jcpowermac commented 6 days ago

/test unit

openshift-ci-robot commented 6 days ago

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1999): >### Changes > >- New feature gate `VSphereHostVMGroupZonal` >- Add `RegionType` and `ZoneType` fields to `VSpherePlatformFailureDomainSpec` to specify region and zone failure domain types. >- Add `VSphereFailureDomainAffinity` type that contains three fields required for vm-host zonal: `VMGroup`, `HostGroup` and `VMHostRule`. >- Add `VSphereFailureDomainAffinity` to `VSpherePlatformTopology` >- Create additional unit tests to cover the introduction of vm-host zonal provisioning types. > >### Additional PRs > >- https://github.com/openshift/enhancements/pull/1677 >- https://github.com/openshift/installer/pull/8873 >- https://github.com/openshift/client-go/pull/294 >- https://github.com/openshift/library-go/pull/1782 >- https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325 >- https://github.com/openshift/machine-api-operator/pull/1285 > >- https://github.com/openshift/api/pull/1999 > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 days ago

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1999): >### Changes > >- New feature gate `VSphereHostVMGroupZonal` >- Add `RegionType` and `ZoneType` fields to `VSpherePlatformFailureDomainSpec` to specify region and zone failure domain types. >- Add `VSphereFailureDomainAffinity` type that contains three fields required for vm-host zonal: `VMGroup`, `HostGroup` and `VMHostRule`. >- Add `VSphereFailureDomainAffinity` to `VSpherePlatformTopology` >- Create additional unit tests to cover the introduction of vm-host zonal provisioning types. >- Add `VMGroup` in a machine(s) workspace. > >### Additional PRs > >- https://github.com/openshift/enhancements/pull/1677 >- https://github.com/openshift/installer/pull/8873 >- https://github.com/openshift/client-go/pull/294 >- https://github.com/openshift/library-go/pull/1782 >- https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325 >- https://github.com/openshift/machine-api-operator/pull/1285 > >- https://github.com/openshift/api/pull/1999 > > > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rvanderp3 commented 6 days ago

/lgtm

openshift-ci[bot] commented 6 days ago

New changes are detected. LGTM label has been removed.

jcpowermac commented 6 days ago

/assign @JoelSpeed

openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac, rvanderp3 Once this PR has been reviewed and has the lgtm label, please ask for approval from joelspeed. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 days ago

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-minor 3ea73d96427f4bef6774d86427905f1921085606 link true /test e2e-upgrade-minor
ci/prow/verify-crd-schema 7642ae7e46150fd302d9358dfa339d85be40eacd link true /test verify-crd-schema
ci/prow/e2e-aws-ovn-techpreview 7642ae7e46150fd302d9358dfa339d85be40eacd link true /test e2e-aws-ovn-techpreview
ci/prow/verify 7642ae7e46150fd302d9358dfa339d85be40eacd link true /test verify
ci/prow/e2e-gcp 7642ae7e46150fd302d9358dfa339d85be40eacd link false /test e2e-gcp
ci/prow/e2e-aws-ovn 7642ae7e46150fd302d9358dfa339d85be40eacd link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).