search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

[release-4.17] OCPBUGS-38605: remove duplicate featuregate 'ExternalRouteCertificate' #2004

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 3 months ago

This is an automated cherry-pick of #1959

/assign chiragkyal

openshift-ci-robot commented 3 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36479 has been cloned as Jira Issue OCPBUGS-38605. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-38605: remove duplicate featuregate 'ExternalRouteCertificate'

In response to [this](https://github.com/openshift/api/pull/2004): >This is an automated cherry-pick of #1959 > >/assign chiragkyal Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 3 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38605, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/2004): >This is an automated cherry-pick of #1959 > >/assign chiragkyal Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chiragkyal commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@chiragkyal: This pull request references Jira Issue OCPBUGS-38605, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/api/pull/2004#issuecomment-2293987206): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chiragkyal commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@chiragkyal: This pull request references Jira Issue OCPBUGS-38605, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36479](https://issues.redhat.com//browse/OCPBUGS-36479) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-36479](https://issues.redhat.com//browse/OCPBUGS-36479) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @lihongan

In response to [this](https://github.com/openshift/api/pull/2004#issuecomment-2293994008): > >/jira refresh > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chiragkyal commented 3 months ago

/assign @JoelSpeed

chiragkyal commented 3 months ago

/test e2e-upgrade-minor

JoelSpeed commented 2 months ago

/test e2e-upgrade-minor

There was a CI outage yesterday, not sure if it's fixed or not, lets try again

JoelSpeed commented 2 months ago

/lgtm /label backport-risk-assessed

Previous discussion about backport in parent PR, good to go once QE can verify

/hold for QE

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/release-4.17/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deads2k commented 2 months ago

/retest

lihongan commented 2 months ago

/label qe-approved pre-merge tested and it works well

$ oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.17.0-0.ci.test-2024-08-21-124406-ci-ln-62d7132-latest   True        False         69m     Cluster version is 4.17.0-0.ci.test-2024-08-21-124406-ci-ln-62d7132-latest

$ oc get featuregates.config.openshift.io cluster -oyaml | grep -i route
    - name: RouteAdvertisements
    - name: RouteExternalCertificate

# QE e2e test
passed: (1m20s) 2024-08-21T14:39:01 "[sig-network-edge] Network_Edge Component_Router should ROSA-OSD_CCS-ARO-Author:hongli-High-73771-router can load secret"
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38605, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36479](https://issues.redhat.com//browse/OCPBUGS-36479) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-36479](https://issues.redhat.com//browse/OCPBUGS-36479) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @lihongan

In response to [this](https://github.com/openshift/api/pull/2004): >This is an automated cherry-pick of #1959 > >/assign chiragkyal Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lihongan commented 2 months ago

/label cherry-pick-approved /unhold

openshift-ci[bot] commented 2 months ago

@lihongan: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

In response to [this](https://github.com/openshift/api/pull/2004#issuecomment-2302223050): >/label cherry-pick-approved >/unhold Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
lihongan commented 2 months ago

I cannot set label cherry-pick-approved, @gangwgr @wangke19 @xingxingxia could you please help add the label? thanks

chiragkyal commented 2 months ago

/retest

chiragkyal commented 2 months ago

I cannot set label cherry-pick-approved

@deads2k can help adding that label

chiragkyal commented 2 months ago

/retest

xingxingxia commented 2 months ago

/label cherry-pick-approved

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD d6942fb7294e5dea4c617bfcb26e5936dc267481 and 2 for PR HEAD 03e29a6a08133d4387c2fb1f9211ab00c1ef134b in total

chiragkyal commented 2 months ago

/retest

JoelSpeed commented 2 months ago 
Aug 22 06:30:43 ip-10-0-181-110 cvo-render[3494]: Error: unknown flag: --feature-gate-manifest-path
Aug 22 06:30:43 ip-10-0-181-110 bootkube.sh[3471]: Error: unknown flag: --feature-gate-manifest-path

The minor upgrade job is broken for 4.17, I fixed for master and 4.18, I'll create another PR

chiragkyal commented 2 months ago

/retest

chiragkyal commented 2 months ago

/test ?

chiragkyal commented 2 months ago

/test all

openshift-ci[bot] commented 2 months ago

@chiragkyal: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/api/pull/2004#issuecomment-2304611458): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD d6942fb7294e5dea4c617bfcb26e5936dc267481 and 2 for PR HEAD 03e29a6a08133d4387c2fb1f9211ab00c1ef134b in total

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD d6942fb7294e5dea4c617bfcb26e5936dc267481 and 2 for PR HEAD 03e29a6a08133d4387c2fb1f9211ab00c1ef134b in total

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-minor 03e29a6a08133d4387c2fb1f9211ab00c1ef134b link true /test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-38605: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38605 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/api/pull/2004): >This is an automated cherry-pick of #1959 > >/assign chiragkyal Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202408222205.p0.g93b6b72.assembly.stream.el9. All builds following this will include this PR.