OCPBUGS-37773: Added checks to prevent vCenters from changing after install past 1 vCenter

[vr4manta]

OCPBUGS-37773

Changes

• Updated infrastructure CRD to have a check for vSphere vCenters field to make sure quantity doesn't change (except for when adding first vCenter after upgrading to newer release)

Notes

The changes in this PR are intended to help prevent having the number of vCenters configured change after cluster is installed. Currently OCP is not going to support updating the number of vCenters as a Day 2 configuration. This will be add in the future, but for now we are going to only allow adding 1 vCenter both as a Day 0 and Day 2 operation. Adding 1 vCenter as Day 2 is allowed to allow older existing clusters, that were installed before the infrastructure object was populated, to be configured for 1 or more failure domains in the existing vSphere it was installed into.

[openshift-ci-robot]

@vr4manta: This pull request references Jira Issue OCPBUGS-37773, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/2006): >OCPBUGS-37773 > >### Changes >- Updated infrastructure CRD to have a check for vSphere vCenters field to make sure quantity doesn't change (except for when adding first vCenter after upgrading to newer release) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[openshift-ci[bot]]

Hello @vr4manta! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[vr4manta]

/test all

[vr4manta]

/retest-required

[vr4manta]

/jira refresh

[openshift-ci-robot]

@vr4manta: This pull request references Jira Issue OCPBUGS-37773, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sgaoshang

In response to [this](https://github.com/openshift/api/pull/2006#issuecomment-2310408421): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[jcpowermac]

/lgtm

[jcpowermac]

/lgtm

[vr4manta]

/retest-required

[JoelSpeed]

/retest

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3c0a506134adc02d5f8879ebdfc16648985243fa and 2 for PR HEAD c85ee335ef84cc1d5caabcdfd409e6d6a6ad3208 in total

[openshift-ci[bot]]

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[openshift-ci-robot]

@vr4manta: Jira Issue OCPBUGS-37773: All pull requests linked via external trackers have merged:

• openshift/api#2006

Jira Issue OCPBUGS-37773 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/api/pull/2006): >[OCPBUGS-37773](https://issues.redhat.com/browse/OCPBUGS-37773) > >### Changes >- Updated infrastructure CRD to have a check for vSphere vCenters field to make sure quantity doesn't change (except for when adding first vCenter after upgrading to newer release) > >### Notes >The changes in this PR are intended to help prevent having the number of vCenters configured change after cluster is installed. Currently OCP is not going to support updating the number of vCenters as a Day 2 configuration. This will be add in the future, but for now we are going to only allow adding 1 vCenter both as a Day 0 and Day 2 operation. Adding 1 vCenter as Day 2 is allowed to allow older existing clusters, that were installed before the infrastructure object was populated, to be configured for 1 or more failure domains in the existing vSphere it was installed into. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[vr4manta]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@vr4manta: new pull request created: #2014

In response to [this](https://github.com/openshift/api/pull/2006#issuecomment-2315479488): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408281541.p0.g01b3675.assembly.stream.el9. All builds following this will include this PR.