search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

[release-4.16] OCPBUGS-38773: remove duplicate featuregate 'ExternalRouteCertificate' #2007

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #1959

/assign chiragkyal

openshift-ci[bot] commented 1 month ago

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36479 has been cloned as Jira Issue OCPBUGS-38773. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-38773: remove duplicate featuregate 'ExternalRouteCertificate'

In response to [this](https://github.com/openshift/api/pull/2007): >This is an automated cherry-pick of #1959 > >/assign chiragkyal Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38773, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/2007): >This is an automated cherry-pick of #1959 > >/assign chiragkyal Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chiragkyal commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@chiragkyal: This pull request references Jira Issue OCPBUGS-38773, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/api/pull/2007#issuecomment-2301492031): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chiragkyal commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@chiragkyal: This pull request references Jira Issue OCPBUGS-38773, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/api/pull/2007#issuecomment-2301496478): > >/jira refresh > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chiragkyal commented 1 month ago

/test all

openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
xingxingxia commented 1 month ago

/label cherry-pick-approved

lihongan commented 1 month ago

/label qe-approved pre-merge tested and passed

$ oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0-0.ci.test-2024-08-22-083316-ci-ln-hhk4byb-latest   True        False         36m     Cluster version is 4.16.0-0.ci.test-2024-08-22-083316-ci-ln-hhk4byb-latest

$ oc get featuregates.config.openshift.io cluster -oyaml | grep -i route
    - name: RouteExternalCertificate

# QE e2e test passed
passed: (1m21s) 2024-08-22T10:10:18 "[sig-network-edge] Network_Edge Component_Router should ROSA-OSD_CCS-ARO-Author:hongli-High-73771-router can load secret"
chiragkyal commented 1 month ago

/assign @JoelSpeed

JoelSpeed commented 1 month ago

/lgtm /label backport-risk-assessed /jira refresh

openshift-ci-robot commented 1 month ago

@JoelSpeed: This pull request references Jira Issue OCPBUGS-38773, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/api/pull/2007#issuecomment-2304468495): >/lgtm >/label backport-risk-assessed >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/release-4.16/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chiragkyal commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@chiragkyal: This pull request references Jira Issue OCPBUGS-38773, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/api/pull/2007#issuecomment-2304473575): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chiragkyal commented 1 month ago

/jira refresh

https://github.com/openshift/api/pull/2004 has to merge first for correct jira dependency

openshift-ci-robot commented 1 month ago

@chiragkyal: This pull request references Jira Issue OCPBUGS-38773, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/api/pull/2007#issuecomment-2304479781): > >/jira refresh > > >https://github.com/openshift/api/pull/2004 has to merge first for correct jira dependency Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
chiragkyal commented 1 month ago

Waiting for an accepted 4.17 nightly build so that OCPBUGS-38605 can be moved to Verified state.

lihongan commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@lihongan: This pull request references Jira Issue OCPBUGS-38773, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-38605](https://issues.redhat.com//browse/OCPBUGS-38605) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-38605](https://issues.redhat.com//browse/OCPBUGS-38605) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @lihongan

In response to [this](https://github.com/openshift/api/pull/2007#issuecomment-2319715940): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-38773: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38773 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/api/pull/2007): >This is an automated cherry-pick of #1959 > >/assign chiragkyal Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.16.0-202408300306.p0.gb7d0481.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.16.0-0.nightly-2024-08-30-061256