openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

OCPBUGS-39300: clean up openshift-sdn references in the API [4.17] #2008

Closed danwinship closed 2 months ago

danwinship commented 3 months ago

backport of #1981 /assign @knobunc

openshift-ci-robot commented 3 months ago

@danwinship: This pull request references SDN-4900 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2008): >backport of #1981 >/assign @knobunc > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

Hello @danwinship! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 3 months ago

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-minor 9843e2e032a8d3ce4a006c069337983c3f20dba7 link true /test e2e-upgrade-minor
ci/prow/e2e-azure 9843e2e032a8d3ce4a006c069337983c3f20dba7 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
knobunc commented 3 months ago

/lgtm /approve /label backport-risk-assessed

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/release-4.17/OWNERS)~~ [knobunc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
abhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@abhat: This pull request references SDN-4900 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2008#issuecomment-2305161721): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
abhat commented 3 months ago

/tide refresh

danwinship commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@danwinship: This pull request references SDN-4900 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2008#issuecomment-2305191796): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
danwinship commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@danwinship: This pull request references SDN-4900 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2008#issuecomment-2305194672): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zhaozhanqi commented 2 months ago

@wangke19 Could you help add cherry-pick-approved ?

gangwgr commented 2 months ago

/label cherry-pick-approved

openshift-ci-robot commented 2 months ago

@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/2008): >backport of #1981 >/assign @knobunc > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
danwinship commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/api/pull/2008#issuecomment-2321600996): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
danwinship commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/api/pull/2008#issuecomment-2321609755): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
danwinship commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/api/pull/2008#issuecomment-2321611860): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
danwinship commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-39301](https://issues.redhat.com//browse/OCPBUGS-39301) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-39301](https://issues.redhat.com//browse/OCPBUGS-39301) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/api/pull/2008#issuecomment-2321613905): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@danwinship: Jira Issue OCPBUGS-39300: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-39300 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/api/pull/2008): >backport of #1981 >/assign @knobunc > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202408301936.p0.g30725dc.assembly.stream.el9. All builds following this will include this PR.

zhaozhanqi commented 2 months ago

/label qe-approved

openshift-ci-robot commented 2 months ago

@danwinship: Jira Issue OCPBUGS-39300: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-39300 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/api/pull/2008): >backport of #1981 >/assign @knobunc > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.