Closed danwinship closed 2 months ago
@danwinship: This pull request references SDN-4900 which is a valid jira issue.
Hello @danwinship! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@danwinship: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-upgrade-minor | 9843e2e032a8d3ce4a006c069337983c3f20dba7 | link | true | /test e2e-upgrade-minor |
ci/prow/e2e-azure | 9843e2e032a8d3ce4a006c069337983c3f20dba7 | link | false | /test e2e-azure |
Full PR test history. Your PR dashboard.
/lgtm /approve /label backport-risk-assessed
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: danwinship, knobunc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/jira refresh
@abhat: This pull request references SDN-4900 which is a valid jira issue.
/tide refresh
/jira refresh
@danwinship: This pull request references SDN-4900 which is a valid jira issue.
/jira refresh
@danwinship: This pull request references SDN-4900 which is a valid jira issue.
@wangke19 Could you help add cherry-pick-approved ?
/label cherry-pick-approved
@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
/jira refresh
@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is invalid:
OCPBUGS
projectComment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
/jira refresh
@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is invalid:
OCPBUGS
projectComment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
/jira refresh
@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
/jira refresh
@danwinship: This pull request references Jira Issue OCPBUGS-39300, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @zhaozhanqi
@danwinship: Jira Issue OCPBUGS-39300: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh
.
Jira Issue OCPBUGS-39300 has not been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202408301936.p0.g30725dc.assembly.stream.el9. All builds following this will include this PR.
/label qe-approved
@danwinship: Jira Issue OCPBUGS-39300: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh
.
Jira Issue OCPBUGS-39300 has not been moved to the MODIFIED state.
backport of #1981 /assign @knobunc