Promote AWSEFSDriverVolumeMetrics to GA

[bertinatto]

With QE's approval, the Storage Team would like to promote this feature to GA in 4.18 and 4.17.

This feature is behind a feature gate because it introduces new fields in the ClusterCSIDriver object. However, it's only used by AWS EFS CSI Driver operator, which is an optional operator installed via OLM.

CC @gcharot @openshift/storage

[openshift-ci[bot]]

Hello @bertinatto! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[chao007]

QE tested steps and resutls as below: 1.oc patch featuregate cluster -p '{"spec": {"featureSet": "TechPreviewNoUpgrade"}}' --type merge

    enabled:
    - name: AWSEFSDriverVolumeMetrics

2.Create clustercsidriver oc get clustercsidriver/efs.csi.aws.com -o json | jq .spec.driverConfig

{
  "aws": {
    "efsVolumeMetrics": {
      "state": "RecursiveWalk"
    }
  },
  "driverType": "AWS"
}

3.Create storageclass/pvc/pod

oc get pvc -n test3
NAME   STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   VOLUMEATTRIBUTESCLASS   AGE
pvc1   Bound    pvc-fcc4f858-21ec-4af3-84a6-54433d7fbc8b   1Gi        RWO            efs-sc         <unset>                 150m

4.Check metrics reported.

      {
        "metric": {
          "__name__": "kubelet_volume_stats_capacity_bytes",
          "endpoint": "https-metrics",
          "instance": "10.0.83.148:10250",
          "job": "kubelet",
          "metrics_path": "/metrics",
          "namespace": "test3",
          "node": "ip-10-0-83-148.us-east-2.compute.internal",
          "persistentvolumeclaim": "pvc1",
          "service": "kubelet"
        },
        "value": [
          1724060972.753,
          "0"
        ] 

5. Update the clustercsidriver

   {
   "aws": {
   "efsVolumeMetrics": {
     "state": "Disabled"
   }
   },
   "driverType": "AWS"
   }

   6.Created pvc/pod 7.Check metrics reported, no values from efs csi driver.

[JoelSpeed]

/lgtm /retest /override ci/prow/verify

No E2E in origin but QE testing shows this is ready

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci[bot]]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/2013#issuecomment-2324123566): >/lgtm >/retest >/override ci/prow/verify > >No E2E in origin but QE testing shows this is ready Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 85dc560939ef05322ce0b204174e9a02c5376c19 and 2 for PR HEAD d51b3e8a63c2931b2793f9a1aa4fefa70299bbdc in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9e399f5fa5fc26e31af8ad56a9840e8e76501a4c and 1 for PR HEAD d51b3e8a63c2931b2793f9a1aa4fefa70299bbdc in total

[bertinatto]

/lgtm /retest /override ci/prow/verify

No E2E in origin but QE testing shows this is ready

/override ci/prow/verify

[openshift-ci[bot]]

@bertinatto: bertinatto unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/api/pull/2013#issuecomment-2324843668): >> /lgtm /retest /override ci/prow/verify >> >> No E2E in origin but QE testing shows this is ready > >/override ci/prow/verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[JoelSpeed]

/override ci/prow/verify

[openshift-ci[bot]]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/2013#issuecomment-2325255631): >/override ci/prow/verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[JoelSpeed]

/retest

[openshift-ci[bot]]

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[bertinatto]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@bertinatto: #2013 failed to apply on top of branch "release-4.17":

Applying: Graduate AWSEFSDriverVolumeMetrics to GA
Using index info to reconstruct a base tree...
M   features/features.go
Falling back to patching base and 3-way merge...
Auto-merging features/features.go
CONFLICT (content): Merge conflict in features/features.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Graduate AWSEFSDriverVolumeMetrics to GA
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to [this](https://github.com/openshift/api/pull/2013#issuecomment-2326779602): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409031742.p0.g1c8de54.assembly.stream.el9. All builds following this will include this PR.