openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

[release-4.17] OCPBUGS-39130: Added checks to prevent vCenters from changing after install past 1 vCenter #2014

Open openshift-cherrypick-robot opened 2 months ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #2006

/assign vr4manta

openshift-ci[bot] commented 2 months ago

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-37773 has been cloned as Jira Issue OCPBUGS-39130. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-39130: Added checks to prevent vCenters from changing after install past 1 vCenter

In response to [this](https://github.com/openshift/api/pull/2014): >This is an automated cherry-pick of #2006 > >/assign vr4manta Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-39130, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/2014): >This is an automated cherry-pick of #2006 > >/assign vr4manta Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vr4manta commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@vr4manta: This pull request references Jira Issue OCPBUGS-39130, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-37773](https://issues.redhat.com//browse/OCPBUGS-37773) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-37773](https://issues.redhat.com//browse/OCPBUGS-37773) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @gpei

In response to [this](https://github.com/openshift/api/pull/2014#issuecomment-2315595712): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jcpowermac commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
pawanpinjarkar commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac, openshift-cherrypick-robot, pawanpinjarkar Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/release-4.17/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vr4manta commented 6 days ago

/assign @JoelSpeed

JoelSpeed commented 1 day ago

@vr4manta Is this a bug backport? Previously we could add more vcenters, but that wasn't supported?

What, apart from this API is required here to complete this?