openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

WRKLDS-1449: disable DynamicResourceAllocation in order to upgrade to resource.k8s.io/v1alpha3 #2016

Closed atiratree closed 2 months ago

openshift-ci-robot commented 2 months ago

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2016): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

Hello @atiratree! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atiratree commented 2 months ago

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview

openshift-ci[bot] commented 2 months ago

@atiratree: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ce99f850-663d-11ef-80ec-3e328423e950-0

atiratree commented 2 months ago

verify-crd-schema error was already present before

error in config/v1/zz_generated.featuregated-crd-manifests/schedulers.config.openshift.io/DynamicResourceAllocationSchedulersConfigOnly.yaml: NoBools: crd/schedulers.config.openshift.io version/v1 field/^.spec.mastersSchedulable may not be a boolean
openshift-ci[bot] commented 2 months ago

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 3bded71f1b515f68b3628edf316aa8c2ac2c8b09 link true /test verify-crd-schema

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
deads2k commented 2 months ago

/hold

Instead of this please update the kube-apiserver operator to check the version it is installing and enable the correct APIs for the level it is installing.

atiratree commented 2 months ago

closing in favor of https://github.com/openshift/cluster-kube-apiserver-operator/pull/1731 and https://github.com/openshift/installer/pull/8973