openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

features: disable PSA #2018

Closed ibihim closed 2 months ago

ibihim commented 2 months ago

What

Disable PodSecurityAdmission

Why

It is too early, we still have too many PS violations.

openshift-ci[bot] commented 2 months ago

Hello @ibihim! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

ibihim commented 2 months ago

/retest-required

ibihim commented 2 months ago

/retest-required

ibihim commented 2 months ago

/retest-required

ibihim commented 2 months ago

/retest-required

ibihim commented 2 months ago

/retest-required

ibihim commented 2 months ago

/retest-required

deads2k commented 2 months ago

/lgtm /approve /backport-risk-assessed

deads2k commented 2 months ago

all the labels!

deads2k commented 2 months ago

/override ci/prow/e2e-azure

openshift-ci[bot] commented 2 months ago

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-azure

In response to [this](https://github.com/openshift/api/pull/2018#issuecomment-2340810961): >/override ci/prow/e2e-azure Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ibihim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/release-4.17/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ibihim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/release-4.17/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 7f4e8b9ffd5dbf17afee63f805c799e5b7214bcb and 2 for PR HEAD 1177f0241d3fedf91f1378fb04839f786dc3bca5 in total

openshift-ci[bot] commented 2 months ago

@ibihim: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202409101836.p0.ga3a93b2.assembly.stream.el9. All builds following this will include this PR.