search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 517 forks source link

[release-4.17] OCPBUGS-38355: Promote AWSEFSDriverVolumeMetrics to GA #2020

Closed bertinatto closed 2 months ago

bertinatto commented 2 months ago

CC @openshift/storage

xref: https://github.com/openshift/api/pull/2013

openshift-ci[bot] commented 2 months ago

Hello @bertinatto! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 2 months ago

@bertinatto: This pull request references Jira Issue OCPBUGS-38355, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/2020): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bertinatto commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@bertinatto: This pull request references Jira Issue OCPBUGS-38355, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-38354](https://issues.redhat.com//browse/OCPBUGS-38354) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-38354](https://issues.redhat.com//browse/OCPBUGS-38354) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @chao007

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/api/pull/2020#issuecomment-2326813412): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
gcharot commented 2 months ago

PM approved for GA promotion in 4.17

knobunc commented 2 months ago

/approve

Staff eng approval for GA promotion

knobunc commented 2 months ago

/label staff-eng-approved

bertinatto commented 2 months ago

/label backport-risk-assessed

openshift-ci[bot] commented 2 months ago

@bertinatto: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to [this](https://github.com/openshift/api/pull/2020#issuecomment-2327367380): >/label backport-risk-assessed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
chao007 commented 2 months ago

lgtm from QE

JoelSpeed commented 2 months ago

/retest-required

chao007 commented 2 months ago

/label cherry-pick-approved /label qe-approved

openshift-ci[bot] commented 2 months ago

@chao007: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

In response to [this](https://github.com/openshift/api/pull/2020#issuecomment-2330394821): >/label cherry-pick-approved >/label qe-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knobunc commented 2 months ago

/label cherry-pick-approved

JoelSpeed commented 2 months ago

/override ci/prow/verify

We only have manual testing for now and QE and Staff eng have signed off

/lgtm

JoelSpeed commented 2 months ago

/label backport-risk-assessed

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, JoelSpeed, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/release-4.17/OWNERS)~~ [JoelSpeed,knobunc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to [this](https://github.com/openshift/api/pull/2020#issuecomment-2331078940): >/override ci/prow/verify > >We only have manual testing for now and QE and Staff eng have signed off > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 5bc57a9aabbe20b8c461ccbe502632220a1e7d33 link false /test e2e-azure
ci/prow/verify 5bc57a9aabbe20b8c461ccbe502632220a1e7d33 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@bertinatto: Jira Issue OCPBUGS-38355: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38355 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/api/pull/2020): >CC @openshift/storage > >xref: https://github.com/openshift/api/pull/2013 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202409051036.p0.g7f4e8b9.assembly.stream.el9. All builds following this will include this PR.