Closed wking closed 2 months ago
Hello @wking! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@wking: This pull request references Jira Issue OCPBUGS-41111, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @jiajliu
The bug has been updated to refer to the pull request using the external bug tracker.
@wking: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deads2k, wking
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@wking: Jira Issue OCPBUGS-41111: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-41111 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409112312.p0.g3e5de94.assembly.stream.el9. All builds following this will include this PR.
These are both synonyms for v4.16, because there have not been capability-recommendation changes since that release. 4.17 is about to go Generally Available, which means v4.17 will always be a synonym for v4.16. v4.18 may or may not evolve before 4.18 goes GA. I think defining synonym capability sets is busywork that takes developer time without adding customer value, but OCPBUGS-41111 points out that so far every 4.y release has had a v4.y capability set string associated with it, and folks might find adjustments to that pattern surprising. I'm declaring sets for our next two 4.y here to continue the existing set-for-each-4.y pattern (and breaking the set-for-each-4.y-with-a-different-default pattern) to unblock 4.17's GA, but we may revisit this approach in the future with more lead time.