Closed deads2k closed 2 months ago
Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@deads2k: This pull request references API-1835 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.
/retest
/hold
need all PRs associated with https://github.com/openshift/api/pull/2030 to merge first.
/hold cancel
manually tested for storage operator. Most library-go operators now direct from api repo.
/test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bertinatto, deads2k
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 1d6161864959881b9b574d30428e574f92ea5c43 and 2 for PR HEAD 8abc53a36e11947c74ef1d1ebe72a5942bf25e94 in total
@deads2k: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409180510.p0.g07bccfd.assembly.stream.el9. All builds following this will include this PR.
as changing the type changes the merge strategy
/lgtm
This will allow coordination between different observers watching the various generations. For instance, what if you want to track different deployments.
Need to vendor into storage, auth, and openshift-apiserver to prove it works ok.
/assign @bertinatto @p0lyn0mial