openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

API-1835: make operator generations behave as a map list type #2029

Closed deads2k closed 2 months ago

deads2k commented 2 months ago

This will allow coordination between different observers watching the various generations. For instance, what if you want to track different deployments.

Need to vendor into storage, auth, and openshift-apiserver to prove it works ok.

/assign @bertinatto @p0lyn0mial

openshift-ci[bot] commented 2 months ago

Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 2 months ago

@deads2k: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2029): >This will allow coordination between different observers watching the various generations. For instance, what if you want to track different deployments. > >Need to vendor into storage, auth, and openshift-apiserver to prove it works ok. > > >/assign @bertinatto @p0lyn0mial Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
deads2k commented 2 months ago

/retest

deads2k commented 2 months ago

/hold

need all PRs associated with https://github.com/openshift/api/pull/2030 to merge first.

deads2k commented 2 months ago

/hold cancel

manually tested for storage operator. Most library-go operators now direct from api repo.

/test all

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 1d6161864959881b9b574d30428e574f92ea5c43 and 2 for PR HEAD 8abc53a36e11947c74ef1d1ebe72a5942bf25e94 in total

openshift-ci[bot] commented 2 months ago

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409180510.p0.g07bccfd.assembly.stream.el9. All builds following this will include this PR.

p0lyn0mial commented 2 months ago

as changing the type changes the merge strategy

/lgtm