Closed deads2k closed 2 months ago
Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@deads2k: This pull request explicitly references no jira issue.
/retest
Change looks fine, and until all CRDs are deployed from this repo, the awkward duplication does save us some E2E cycles, so, lets keep this approach for now and once we are complete, we can remove the duplication
/lgtm
/hold
Holding in case this needs to be released in a particular time window
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deads2k, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
New changes are detected. LGTM label has been removed.
clusterbot cluster installed correctly. Merging and will get the others later to help the nightly image build likelihood.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409171909.p0.g1d61618.assembly.stream.el9. All builds following this will include this PR.
to come in other PRs, MCO stuff, image registry, network edge, storage.
/assign @JoelSpeed