openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

NO-jIRA: move some operator crds to openshift/api #2030

Closed deads2k closed 2 months ago

deads2k commented 2 months ago
  1. etcd
  2. kube-apiserver
  3. kube-controller-manager
  4. kube-scheduler
  5. openshift-apiserver
  6. openshift-controller-manager
  7. openshift-authentication

to come in other PRs, MCO stuff, image registry, network edge, storage.

/assign @JoelSpeed

openshift-ci[bot] commented 2 months ago

Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 2 months ago

@deads2k: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/api/pull/2030): >1. etcd >2. kube-apiserver >3. kube-controller-manager >4. kube-scheduler >5. openshift-apiserver >6. openshift-controller-manager >7. openshift-authentication > >to come in other PRs, MCO stuff, image registry, network edge, storage. > >/assign @JoelSpeed Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
deads2k commented 2 months ago

/retest

JoelSpeed commented 2 months ago

Change looks fine, and until all CRDs are deployed from this repo, the awkward duplication does save us some E2E cycles, so, lets keep this approach for now and once we are complete, we can remove the duplication

/lgtm

/hold

Holding in case this needs to be released in a particular time window

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed,deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

New changes are detected. LGTM label has been removed.

deads2k commented 2 months ago

clusterbot cluster installed correctly. Merging and will get the others later to help the nightly image build likelihood.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409171909.p0.g1d61618.assembly.stream.el9. All builds following this will include this PR.