openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

NO-JIRA: move storage CRDs to openshift/api #2032

Closed bertinatto closed 2 months ago

bertinatto commented 2 months ago

This is a follow-up to https://github.com/openshift/api/pull/2030.

This makes the promotion of featuregates more atomic, as the CRD schema changes in the same PR that changes the feature.

This will prevent changes like this when adding new TechPreview fields to ClusterCSIDriver CRDs.

CC @openshift/storage

openshift-ci-robot commented 2 months ago

@bertinatto: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/api/pull/2032): >This is a follow-up to https://github.com/openshift/api/pull/2030. > >/hold >Until all PRs associated with https://github.com/openshift/api/pull/2030 are merged and we're sure this works. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

Hello @bertinatto! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

deads2k commented 2 months ago

/lgtm /hold

Due to some out of sync-ness, the order needs to be

  1. update https://github.com/openshift/cluster-storage-operator with latest openshift/api and merge
  2. then re-test this PR for green and merge (notice verify is red now)
  3. then, shortly after merge https://github.com/openshift/cluster-storage-operator/pull/505/files.

But the change here lgtm.

bertinatto commented 2 months ago

/hold cancel

deads2k commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 8f6ded478e8ab589ade8749fb3b70a0fb90a0e60 and 2 for PR HEAD de692e9b13092a1b83f8d4b2d2f2e2c20cbd01c7 in total

bertinatto commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409200008.p0.g2669d1e.assembly.stream.el9. All builds following this will include this PR.