Closed bertinatto closed 2 months ago
@bertinatto: This pull request explicitly references no jira issue.
Hello @bertinatto! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
/lgtm /hold
Due to some out of sync-ness, the order needs to be
But the change here lgtm.
/hold cancel
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bertinatto, deads2k
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 8f6ded478e8ab589ade8749fb3b70a0fb90a0e60 and 2 for PR HEAD de692e9b13092a1b83f8d4b2d2f2e2c20cbd01c7 in total
/retest-required
@bertinatto: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409200008.p0.g2669d1e.assembly.stream.el9. All builds following this will include this PR.
This is a follow-up to https://github.com/openshift/api/pull/2030.
This makes the promotion of featuregates more atomic, as the CRD schema changes in the same PR that changes the feature.
This will prevent changes like this when adding new TechPreview fields to ClusterCSIDriver CRDs.
CC @openshift/storage