Closed deads2k closed 2 months ago
Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
this can merge before, but we want the timing to be very close because any change to one of these types will product weird conflicts in the cluster until we merge the other one.
oh, and clusterbot tested these two together fine.
/override ci/prow/e2e-upgrade
network sandbox.
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-upgrade
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deads2k, yuqi-zhang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 07bccfd9266faa9565b51fad64e7a773bfb0f8a6 and 2 for PR HEAD 8f68f407d06c1cfd779319d8996f47a52b75c2e0 in total
/retest-required
Remaining retests: 0 against base HEAD 07bccfd9266faa9565b51fad64e7a773bfb0f8a6 and 2 for PR HEAD 8f68f407d06c1cfd779319d8996f47a52b75c2e0 in total
@deads2k: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409190709.p0.g8f6ded4.assembly.stream.el9. All builds following this will include this PR.
this makes promotion of featuregates more atomic as the CRD schema for Default changes in the same PR that makes the feature default.
/cc @yuqi-zhang