openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

copy mco crds to be managed by openshfit/api #2033

Closed deads2k closed 2 months ago

deads2k commented 2 months ago

this makes promotion of featuregates more atomic as the CRD schema for Default changes in the same PR that makes the feature default.

/cc @yuqi-zhang

openshift-ci[bot] commented 2 months ago

Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

deads2k commented 2 months ago

test with https://github.com/openshift/machine-config-operator/pull/4597

deads2k commented 2 months ago

this can merge before, but we want the timing to be very close because any change to one of these types will product weird conflicts in the cluster until we merge the other one.

deads2k commented 2 months ago

oh, and clusterbot tested these two together fine.

deads2k commented 2 months ago

/override ci/prow/e2e-upgrade

network sandbox.

openshift-ci[bot] commented 2 months ago

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-upgrade

In response to [this](https://github.com/openshift/api/pull/2033#issuecomment-2358777206): >/override ci/prow/e2e-upgrade > >network sandbox. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yuqi-zhang commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 07bccfd9266faa9565b51fad64e7a773bfb0f8a6 and 2 for PR HEAD 8f68f407d06c1cfd779319d8996f47a52b75c2e0 in total

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 07bccfd9266faa9565b51fad64e7a773bfb0f8a6 and 2 for PR HEAD 8f68f407d06c1cfd779319d8996f47a52b75c2e0 in total

openshift-ci[bot] commented 2 months ago

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409190709.p0.g8f6ded4.assembly.stream.el9. All builds following this will include this PR.