search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 516 forks source link

API-1843: FeatureGate(d) KMS encryption #2035

Open swghosh opened 1 month ago

swghosh commented 1 month ago

This feature is primarily targeted for SelfManagedHA OpenShift TechPreview.

Feature Gate PR: https://github.com/openshift/api/pull/2071

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

Hello @swghosh! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swghosh Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@swghosh: This pull request references API-1843 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2035): >This feature is primarily targeted for SelfManagedHA OpenShift TechPreview. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
swghosh commented 1 month ago

/cc @dgrisonnet @tkashem

JoelSpeed commented 3 weeks ago

/hold per https://github.com/openshift/api/pull/2071#issuecomment-2431322266

swghosh commented 3 weeks ago

/remove-hold @JoelSpeed feel free to re-review, thanks!

JoelSpeed commented 3 weeks ago

The EP for this feature doesn't yet have any review, lets get some initial review going on the EP first before we get too much into perfecting the API (else it may change massively based on EP feedback from other stakeholders)

openshift-ci-robot commented 3 weeks ago

@swghosh: This pull request references API-1843 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2035): >This feature is primarily targeted for SelfManagedHA OpenShift TechPreview. > >Feature Gate PR: https://github.com/openshift/api/pull/2071 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 days ago

@swghosh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 6fc18753a30b10b118de260ab0efa431ef4e0f56 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-serial 6fc18753a30b10b118de260ab0efa431ef4e0f56 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-techpreview 6fc18753a30b10b118de260ab0efa431ef4e0f56 link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).