API-1835: prevent empty low level condition types

[deads2k]

we tried to prevent this and had a bug. The empty condition type is not very useful and should be prevented.

Since this is the low-level operator status, the number of writers should only be our operators (they own their own status), so tightening, while painful, is possible.

/assign @bertinatto

[openshift-ci[bot]]

Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@deads2k: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2037): >we tried to prevent this and had a bug. The empty condition type is not very useful and should be prevented. > >Since this is the low-level operator status, the number of writers should only be our operators (they own their own status), so tightening, while painful, is possible. > >/assign @bertinatto Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[bertinatto]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2669d1ebc91092ec32e77b1d3f503b11f759b855 and 2 for PR HEAD 59e7cb14d950ff4855fa435781b461e2de6a8d7b in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2669d1ebc91092ec32e77b1d3f503b11f759b855 and 2 for PR HEAD 59e7cb14d950ff4855fa435781b461e2de6a8d7b in total

[deads2k]

/hold

no need to retest these until we fix lasttransition time.

[openshift-ci[bot]]

@bertinatto: This PR was included in a payload test run from openshift/gcp-pd-csi-driver-operator#127 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.18-e2e-gcp-ovn-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2e3b9680-7b72-11ef-93fe-4a17220dd333-0

[deads2k]

we are intentionally tightening

/override ci/prow/verify-crd-schema

[openshift-ci[bot]]

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2037#issuecomment-2375150336): >we are intentionally tightening > >/override ci/prow/verify-crd-schema Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[deads2k]

/retest

[deads2k]

/test all

[bertinatto]

@bertinatto: This PR was included in a payload test run from openshift/gcp-pd-csi-driver-operator#127 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

* periodic-ci-openshift-release-master-nightly-4.18-e2e-gcp-ovn-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2e3b9680-7b72-11ef-93fe-4a17220dd333-0

/lgtm

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[deads2k]

/override ci/prow/verify-crd-schema

[openshift-ci[bot]]

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2037#issuecomment-2375469842): >/override ci/prow/verify-crd-schema Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[deads2k]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3c700b6cb32b58a619428e246b4ad5040565ac13 and 2 for PR HEAD 32bea81091afe210c646e543a58c2e5a367d30ff in total

[openshift-ci[bot]]

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	32bea81091afe210c646e543a58c2e5a367d30ff	link	false	/test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409260508.p0.g46b9486.assembly.stream.el9. All builds following this will include this PR.