Closed deads2k closed 1 month ago
Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@deads2k: This pull request references API-1835 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.
/retest
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bertinatto, deads2k
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD 232984653385c77e0d6bb8c3d4ec6007de618ace and 2 for PR HEAD a2c8c524ce706ac7a95a2b14c89d172c2fbfbc6a in total
@deads2k: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409250208.p0.g3c700b6.assembly.stream.el9. All builds following this will include this PR.
This field was used in a couple operators deploying apiservers. My guess is that it is necessary for KMS.
Also add validation to prevent moving revisions backwards, which would do really bad things.
/assign @bertinatto @p0lyn0mial