Closed bertinatto closed 1 month ago
Hello @bertinatto! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bertinatto Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/test all
@bertinatto: This PR was included in a payload test run from openshift/gcp-pd-csi-driver-operator#127 trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/db7235b0-7b50-11ef-9103-73108b1990d1-0
@bertinatto: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/minor-e2e-upgrade-minor | 031515754b3a17dee3f1a5c807cd9236352a4118 | link | true | /test minor-e2e-upgrade-minor |
ci/prow/e2e-gcp | 031515754b3a17dee3f1a5c807cd9236352a4118 | link | false | /test e2e-gcp |
ci/prow/e2e-upgrade | 031515754b3a17dee3f1a5c807cd9236352a4118 | link | true | /test e2e-upgrade |
ci/prow/verify-crd-schema | 031515754b3a17dee3f1a5c807cd9236352a4118 | link | true | /test verify-crd-schema |
Full PR test history. Your PR dashboard.
Just an updated version of https://github.com/openshift/api/pull/2037 for testing purposes.
Not to merge.
/hold