Open miheer opened 4 days ago
@miheer: This pull request references CORS-3689 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
Hello @miheer! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: miheer Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@miheer: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-aws-serial-techpreview | b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf | link | true | /test e2e-aws-serial-techpreview |
ci/prow/e2e-aws-ovn | b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf | link | true | /test e2e-aws-ovn |
ci/prow/verify | b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf | link | true | /test verify |
ci/prow/e2e-azure | b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf | link | false | /test e2e-azure |
ci/prow/e2e-aws-serial | b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf | link | true | /test e2e-aws-serial |
ci/prow/e2e-aws-ovn-techpreview | b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf | link | true | /test e2e-aws-ovn-techpreview |
ci/prow/verify-crd-schema | b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf | link | true | /test verify-crd-schema |
ci/prow/e2e-gcp | b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf | link | false | /test e2e-gcp |
Full PR test history. Your PR dashboard.
The eipAllocations when set by installer for default AWS NLB IngressController are set in the cluster ingress object the for the ingress operator to refer and then create a default Ingress Controller. This API field holds the eipAllocations value set by installer which were set via install-config.yaml