openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

CORS-3689: API changes in config/v1 to hold eipAllocations in cluster ingress object. #2043

Open miheer opened 4 days ago

miheer commented 4 days ago

The eipAllocations when set by installer for default AWS NLB IngressController are set in the cluster ingress object the for the ingress operator to refer and then create a default Ingress Controller. This API field holds the eipAllocations value set by installer which were set via install-config.yaml

openshift-ci-robot commented 4 days ago

@miheer: This pull request references CORS-3689 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2043): >The eipAllocations when set by installer for default AWS NLB IngressController are set in the cluster ingress object the for the ingress operator to refer and then create a default Ingress Controller. This API field holds the eipAllocations value set by installer which were set via install-config.yaml Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 days ago

Hello @miheer! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miheer Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 days ago

@miheer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf link true /test e2e-aws-ovn
ci/prow/verify b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf link true /test verify
ci/prow/e2e-azure b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf link false /test e2e-azure
ci/prow/e2e-aws-serial b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-techpreview b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf link true /test e2e-aws-ovn-techpreview
ci/prow/verify-crd-schema b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf link true /test verify-crd-schema
ci/prow/e2e-gcp b5a1cd65e1479720e0a0f8f2fac35c37dc38abdf link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).