search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

TRT-1831: Revert #2037 "API-1835: prevent empty low level condition types" #2045

Closed sosiouxme closed 1 month ago

sosiouxme commented 1 month ago

Reverts #2037 ; tracked by TRT-1831

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Just floating this since we have no other candidate changes

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

run nightly aggregated e.g. /payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

CC: @deads2k

PR created by Revertomatic:tm:
openshift-ci-robot commented 1 month ago

@sosiouxme: This pull request references TRT-1831 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2045): > >Reverts #2037 ; tracked by [TRT-1831](https://issues.redhat.com//browse/TRT-1831) > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >Just floating this since we have no other candidate changes > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >run nightly aggregated e.g. /payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade >``` > >CC: @deads2k > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@sosiouxme: This pull request references TRT-1831 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2045): > >Reverts #2037 ; tracked by [TRT-1831](https://issues.redhat.com//browse/TRT-1831) > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >Just floating this since we have no other candidate changes > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >run nightly aggregated e.g. /payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade >``` > >CC: @deads2k > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Hello @sosiouxme! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

sosiouxme commented 1 month ago

/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

openshift-ci[bot] commented 1 month ago

@sosiouxme: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

sosiouxme commented 1 month ago

/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade 10

openshift-ci[bot] commented 1 month ago

@sosiouxme: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/64001a90-7c24-11ef-8bee-0b180557d5b3-0

deads2k commented 1 month ago

/lgtm /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sosiouxme commented 1 month ago

/override ci/prow/e2e-upgrade

openshift-ci[bot] commented 1 month ago

@sosiouxme: Overrode contexts on behalf of sosiouxme: ci/prow/e2e-upgrade

In response to [this](https://github.com/openshift/api/pull/2045#issuecomment-2377947121): >/override ci/prow/e2e-upgrade > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sosiouxme commented 1 month ago

ok i didn't think tide cared about hypershift but /override ci/prow/e2e-aws-ovn-hypershift

openshift-ci[bot] commented 1 month ago

@sosiouxme: Overrode contexts on behalf of sosiouxme: ci/prow/e2e-aws-ovn-hypershift

In response to [this](https://github.com/openshift/api/pull/2045#issuecomment-2377954367): >ok i didn't think tide cared about hypershift but >/override ci/prow/e2e-aws-ovn-hypershift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@sosiouxme: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409262341.p0.gf89ab92.assembly.stream.el9. All builds following this will include this PR.