openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

API-1835: prevent empty conditions #2048

Closed deads2k closed 1 month ago

deads2k commented 1 month ago

unreverts https://github.com/openshift/api/pull/2045

openshift-ci[bot] commented 1 month ago

Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

deads2k commented 1 month ago

/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade

expecting^ this to fail until https://github.com/openshift/cluster-authentication-operator/pull/703 lands. Let's see how it goes.

/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade

expecting^ this to succeed now that the 4.18 version has landed

openshift-ci[bot] commented 1 month ago

@deads2k: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

deads2k commented 1 month ago

/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade 10

openshift-ci[bot] commented 1 month ago

@deads2k: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d3399d70-7d0d-11ef-97a3-bcf639c09248-0

openshift-ci-robot commented 1 month ago

@deads2k: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2048): >unreverts https://github.com/openshift/api/pull/2045 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
deads2k commented 1 month ago

kas-o is missing last transition time. Sigh

deads2k commented 1 month ago

kube-controller-manager, kube-scheduler

Will update these and try again in a bit.

deads2k commented 1 month ago

Filip happened to bump all these things and accepted in https://amd64.ocp.releases.ci.openshift.org/releasestream/4.18.0-0.ci/release/4.18.0-0.ci-2024-10-02-015545

/test all

openshift-ci[bot] commented 1 month ago

@deads2k: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

deads2k commented 1 month ago

once https://github.com/openshift/cluster-authentication-operator/pull/703 merges and we get a 4.17 payload, we'll try the aggregation again.

deads2k commented 1 month ago

/payload-aggregate periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade 10

openshift-ci[bot] commented 1 month ago

@deads2k: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3ecba300-81a3-11ef-80a5-c3433b1cc866-0

deads2k commented 1 month ago

/override ci/prow/verify-crd-schema

openshift-ci[bot] commented 1 month ago

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2048#issuecomment-2391861322): >/override ci/prow/verify-crd-schema Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
deads2k commented 1 month ago

Green!

/hold cancel

openshift-ci[bot] commented 1 month ago

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410040439.p0.g4c68b61.assembly.stream.el9. All builds following this will include this PR.