search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

STOR-1823: Remove CSIDriverSharedResource feature gate #2052

Open dobsonj opened 1 month ago

dobsonj commented 1 month ago

https://issues.redhat.com/browse/STOR-1823

/hold for https://github.com/openshift/cluster-storage-operator/pull/509

/cc @openshift/storage @adambkaplan @sayan-biswas

openshift-ci-robot commented 1 month ago

@dobsonj: This pull request references STOR-1823 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2052): >https://issues.redhat.com/browse/STOR-1823 > >/hold for https://github.com/openshift/cluster-storage-operator/pull/509 > >/cc @openshift/storage @adambkaplan @sayan-biswas > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Hello @dobsonj! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 1 month ago

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/api/pull/2052): >https://issues.redhat.com/browse/STOR-1823 > >/hold for https://github.com/openshift/cluster-storage-operator/pull/509 > >/cc @openshift/storage @adambkaplan @sayan-biswas > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jsafrane commented 1 month ago

lgtm from storage POV /hold for https://github.com/openshift/origin/pull/29130 to be merged first

dobsonj commented 1 month ago

/retest

dobsonj commented 4 weeks ago

/unhold https://github.com/openshift/cluster-storage-operator/pull/509 and https://github.com/openshift/origin/pull/29130 merged so we can remove this featuregate any time.

dobsonj commented 3 weeks ago

/retest

knobunc commented 2 days ago

/approve

dobsonj commented 2 days ago

/retest-required

gnufied commented 2 days ago

/lgtm

openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, gnufied, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [knobunc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dobsonj commented 2 days ago

/label acknowledge-critical-fixes-only

dobsonj commented 2 days ago

/retest-required

openshift-ci-robot commented 2 days ago

/retest-required

Remaining retests: 0 against base HEAD caf97963ed302881f01e67b791ae4efc6bcf723c and 2 for PR HEAD c6b10686ee3540c198c7b9bc1cda73db95bd15fc in total

openshift-ci-robot commented 1 day ago

/retest-required

Remaining retests: 0 against base HEAD caf97963ed302881f01e67b791ae4efc6bcf723c and 2 for PR HEAD c6b10686ee3540c198c7b9bc1cda73db95bd15fc in total

dobsonj commented 1 day ago

/retest-required

openshift-ci-robot commented 1 day ago

/retest-required

Remaining retests: 0 against base HEAD caf97963ed302881f01e67b791ae4efc6bcf723c and 2 for PR HEAD c6b10686ee3540c198c7b9bc1cda73db95bd15fc in total

openshift-ci-robot commented 19 hours ago

/retest-required

Remaining retests: 0 against base HEAD ec9bf3faa1aa2f52805c44b7b13cd7ab4b984241 and 1 for PR HEAD c6b10686ee3540c198c7b9bc1cda73db95bd15fc in total

openshift-ci-robot commented 14 hours ago

/retest-required

Remaining retests: 0 against base HEAD c98acdb0b66c1ba022db2bd79b7ac40316f61a3e and 0 for PR HEAD c6b10686ee3540c198c7b9bc1cda73db95bd15fc in total

openshift-ci-robot commented 13 hours ago

/hold

Revision c6b10686ee3540c198c7b9bc1cda73db95bd15fc was retested 3 times: holding

dobsonj commented 13 hours ago

/unhold

openshift-ci-robot commented 12 hours ago

/retest-required

Remaining retests: 0 against base HEAD 053bb8a33f6d0424b025c830eedebc4a0b61fcd5 and 2 for PR HEAD c6b10686ee3540c198c7b9bc1cda73db95bd15fc in total

dobsonj commented 9 hours ago

/retest

openshift-ci[bot] commented 3 hours ago

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview c6b10686ee3540c198c7b9bc1cda73db95bd15fc link unknown /test e2e-aws-serial-techpreview
ci/prow/okd-scos-e2e-aws-ovn c6b10686ee3540c198c7b9bc1cda73db95bd15fc link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).