search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

NE-1790: Introduce IngressControllerDynamicConfigurationManager feature gate #2057

Closed alebedev87 closed 1 month ago

alebedev87 commented 1 month ago

This PR adds a new feature gate for a long time implemented feature of OpenShift Router: Dynamic Configuration Manager (DCM). DCM has been introduced in OCP 3.11 as an opt-in feature. It stayed disabled by default since then. This feature gate aims at enabling DCM by default to help solving the recurring problem of HAProxy's excessive memory consumption during the configuration reloads.

openshift-ci-robot commented 1 month ago

@alebedev87: This pull request references NE-1790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2057): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Hello @alebedev87! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

alebedev87 commented 1 month ago

/retest

openshift-ci-robot commented 1 month ago

@alebedev87: This pull request references NE-1790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2057): >This PR adds a new feature gate for a long time implemented feature of OpenShift Router: Dynamic Configuration Manager (DCM). The manager has been introduced in [OCP 3.11 as an opt-in feature](https://docs.openshift.com/container-platform/3.11/install_config/router/default_haproxy_router.html#using-the-dynamic-configuration-manager). It stayed disabled by default since then. This feature gate aims at enabling DCM to help solving the recurring problem of HAProxy's excessive memory consumption during the configuration reloads. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@alebedev87: This pull request references NE-1790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2057): >This PR adds a new feature gate for a long time implemented feature of OpenShift Router: Dynamic Configuration Manager (DCM). DCM has been introduced in [OCP 3.11 as an opt-in feature](https://docs.openshift.com/container-platform/3.11/install_config/router/default_haproxy_router.html#using-the-dynamic-configuration-manager). It stayed disabled by default since then. This feature gate aims at enabling DCM by default to help solving the recurring problem of HAProxy's excessive memory consumption during the configuration reloads. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
JoelSpeed commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 5afd6c371db482cf923b80bd13935c2830a0f357 and 2 for PR HEAD aadaa6d68993de4fe600fb5a5fcc5581c2a61338 in total

openshift-ci[bot] commented 1 month ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410170240.p0.g92a3906.assembly.stream.el9. All builds following this will include this PR.