search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

ipam, virt: graduate persistent ips feature gate to GA #2058

Open maiqueb opened 1 month ago

maiqueb commented 1 month ago

This PR graduates the PersistentIPsForVirtualization feature gate to GA.

openshift-ci[bot] commented 1 month ago

Hello @maiqueb! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maiqueb Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maiqueb commented 1 week ago

/test verify

openshift-ci[bot] commented 1 week ago

@maiqueb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial 871751504da5f69e0243cba40fe5a6cdc83ecc12 link true /test e2e-aws-serial
ci/prow/e2e-aws-serial-techpreview 871751504da5f69e0243cba40fe5a6cdc83ecc12 link true /test e2e-aws-serial-techpreview
ci/prow/minor-e2e-upgrade-minor 871751504da5f69e0243cba40fe5a6cdc83ecc12 link true /test minor-e2e-upgrade-minor
ci/prow/verify 871751504da5f69e0243cba40fe5a6cdc83ecc12 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).